question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

MyPy: improve ignite.contrib module

See original GitHub issue

🚀 Feature

The ignite.contrib module is the last one, which is ignored by the mypy config 💪 For anyone, who wants to do it, I would recommend to split it in 3-4 PRs

  • ignite.contrib.engines
  • ignite.contrib.handlers
  • ignite.contrib.metrics
  • (Optional separate PR) ignite.contrib.metrics.regression

After that we could also enable more stricter mypy configuration to further improve the typing of the project.

So, feel free to ask any questions here or in your PRs, I will try my best to give proper guidance and @vfdev-5 will do the same for sure, like he did with my previous PRs 👍

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:1
  • Comments:10 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
zhxxncommented, Oct 28, 2020

I just finished my work on ignite.contrib.metrics. Next I would like to try ignite.contrib.handlers 😄

0reactions
vfdev-5commented, Nov 24, 2020

@gruebel thanks !

Read more comments on GitHub >

github_iconTop Results From Across the Web

The mypy configuration file - mypy 0.991 documentation
(This will help us catch typos when making changes to our config file). Next, this module specifies three per-module options. The first two...
Read more >
pytorch-ignite Changelog - pyup.io
Improved logging time taken message showing milliseconds (2650) Metrics and handlers ... Introduction of `ignite.distributed as idist` module (1045)
Read more >
Our journey to type checking 4 million lines of Python - Dropbox
(Mypy is an open source project, and the core team is employed by ... we also contributed improved type definitions (a.k.a. stub files)...
Read more >
Mypy 0.800 Released
We now provide compiled binary wheels for Python 3.9, improving type ... on the command line, and mypy can better infer their module...
Read more >
python/typing - Gitter
(venv) PS D:\Documents\Matt\Projects\pixelmatch-py> mypy . pixelmatch\contrib\PIL.py:4: error: No library stub file for module 'PIL.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found