Should we have import of Engine in ignite/__init__.py?
See original GitHub issue@elanmart thanks for the DCGAN PR - looks great!
Just noticed in the PR that
from ignite.engine.engine import Engine, Events, State
was added to ignite/__init__.py
?
I understand that it does add some convenience so users can just use the Engine, but this also creates inconsistent usage patterns i.e.
import ignite
engine = ignite.Engine(...)
and
from ignite.engine import Engine, State, Events
engine = Engine()
perhaps we could just add
import ignite.engine
import ignite.handlers
etc. in the __init__.py
file in ignite/
, similar to what’s done in pytorch (i.e. here)
cc @vfdev-5
Issue Analytics
- State:
- Created 5 years ago
- Reactions:1
- Comments:5 (4 by maintainers)
Top Results From Across the Web
Importing a Motor Vehicle | U.S. Customs and Border Protection
Conforming vehicles imported under the duty-free exemption are dutiable if sold within one year of importation. Duty must be paid at the most ......
Read more >Importing Vehicles and Engines into the United States | US EPA
This site describes EPA emission regulations and requirements for importing motor vehicles, motor vehicle engines, heavy-duty on-highway ...
Read more >Importation and Certification FAQs - NHTSA
Motor vehicle manufacturers are not required to submit to NHTSA, and do not ... If the vehicle you are seeking to import is...
Read more >Memorandum D19-12-1 - Importation of vehicles
Vehicles that do not qualify for importation under one of the two preceding options are considered inadmissible and cannot be imported into Canada....
Read more >How does SQLAlchemy create_engine import Engine class?
Your Python script is imported as the __main__ namespace, and all names in it are available to your script. If you create a...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Right, so we can change the imports of
ignite/__init__.py
toSo, I can change it if you do not have any objections
Merged in #180