question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Should we have import of Engine in ignite/__init__.py?

See original GitHub issue

@elanmart thanks for the DCGAN PR - looks great!

Just noticed in the PR that

from ignite.engine.engine import Engine, Events, State

was added to ignite/__init__.py?

I understand that it does add some convenience so users can just use the Engine, but this also creates inconsistent usage patterns i.e.

import ignite
engine = ignite.Engine(...)

and

from ignite.engine import Engine, State, Events
engine = Engine()

perhaps we could just add

import ignite.engine
import ignite.handlers

etc. in the __init__.py file in ignite/, similar to what’s done in pytorch (i.e. here)

cc @vfdev-5

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:1
  • Comments:5 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
vfdev-5commented, May 11, 2018

Right, so we can change the imports of ignite/__init__.py to

import ignite.engine
import ignite.handlers

So, I can change it if you do not have any objections

0reactions
alykhantejanicommented, May 16, 2018

Merged in #180

Read more comments on GitHub >

github_iconTop Results From Across the Web

Importing a Motor Vehicle | U.S. Customs and Border Protection
Conforming vehicles imported under the duty-free exemption are dutiable if sold within one year of importation. Duty must be paid at the most ......
Read more >
Importing Vehicles and Engines into the United States | US EPA
This site describes EPA emission regulations and requirements for importing motor vehicles, motor vehicle engines, heavy-duty on-highway ...
Read more >
Importation and Certification FAQs - NHTSA
Motor vehicle manufacturers are not required to submit to NHTSA, and do not ... If the vehicle you are seeking to import is...
Read more >
Memorandum D19-12-1 - Importation of vehicles
Vehicles that do not qualify for importation under one of the two preceding options are considered inadmissible and cannot be imported into Canada....
Read more >
How does SQLAlchemy create_engine import Engine class?
Your Python script is imported as the __main__ namespace, and all names in it are available to your script. If you create a...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found