Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

TrainsSaver requires TrainsLogger but doesn't use it

See original GitHub issue

❓ Questions/Help/Support

Hi,

I’m opening this issue as a question, because I’m not sure if it’s an artifact or it has an intended purpose that I don’t understand.

The new trains support introduced TrainsSaver together with TrainsLogger. It seems that to initialize the TrainsSaver object, you’re required to pass a TrainsLogger logger (https://github.com/pytorch/ignite/blob/master/ignite/contrib/handlers/trains_logger.py#L610). However, this logger is not used anywhere. Why is it required?

I would expect to be able to just do

Checkpoint(to_save, TrainsSaver(output_uri=output_uri), 'epoch', n_saved=n_saved,
                       global_step_transform=global_step_from_engine(trainer))

Issue Analytics

State:
Created 3 years ago
Comments:9 (6 by maintainers)

Top GitHub Comments

3reactions

jkhenningcommented, May 16, 2020

Created https://github.com/pytorch/ignite/pull/1043 😄

1reaction

achigeorcommented, May 15, 2020

@jkhenning yeap makes a lot of sense, this covers all usecases for advanced as well as new users as you said 👍

Top Results From Across the Web

Travel Guide to Train Fares - Easy Online Booking Options

Saver Fares are the lowest available fares and require advance purchase. Saver Fares are limited in availability and generally require advance purchase.

German Train Tickets Explained: Understanding Deutsche Bahn

Saver (Sparen) Tickets These tickets are going to be cheaper than the Flexpreis DB Tickets. When you go to book, you will need...

Should I Get a Rail Pass? - Rick Steves Europe

By Rick Steves. A train traveler's biggest pretrip decision is whether to get a rail pass or stick with point-to-point tickets (or use...

Amtrak Discounts: A Guide to Cheaper Train Tickets | Frommer's

Use these promo codes and dedicated links to save up to 20% on your train ... NARP doesn't have any membership requirements beyond...

Beginner's guide to Eurail passes - Seat 61

Forgive me for saying so, but overseas visitors sometimes seem brainwashed into thinking that they have to buy a Eurail pass to use...