models "all" option only starts first mode found in model store

Issue

Torchserve start with models “all” option only starts the first model found in the model store unless snapshots are disabled. All models are started if the --ncs option is added.

Only first model is started

torchserve --start --model-store model_store --models all

All models are started

torchserve --start --ncs --model-store model_store --models all

• torchserve version: 0.1.1
• Operating System and version: ubuntu 18.04

Environment

• Installed using source? [yes/no]: yes
• Are you planning to deploy it using docker container? [yes/no]: no
• Is it a CPU or GPU environment?: GPU
• Using a default/custom handler? [If possible upload/share custom handler/model]: Using Custom Handlers
• What kind of model is it e.g. vision, text, audio?: Image Segmentation
• Are you planning to use local models from model-store or public url being used e.g. from S3 bucket etc.? [If public url then provide link.]: Local model store
• Provide config.properties, logs [ts.log] and parameters used for model registration/update APIs:
• Link to your project [if any]:

Expected Behavior

The “all” option should start all the models found in the model store

Current Behavior

Only the first model found is started unless the --ncs option is supplied

Steps to Reproduce

1. Create two .mar files
2. Add both .mar files to a model store
3. Start torchserve using the below command

torchserve --start --model-store model_store --models all

1. Run the below command to query for running models and observe only a single model is running

curl "http://localhost:8081/models

{
  "models": [
    {
      "modelName": "model_1",
      "modelUrl": "model_1.mar"
    }
  ]
}

1. Stop torchserve

torchserve --stop

1. Start torchserve using the below command disabling the snapshots feature

torchserve --start --ncs --model-store model_store --models all

1. Run the below command to query for running models and observe both models are running

curl "http://localhost:8081/models

{
  "models": [
    {
      "modelName": "model_1",
      "modelUrl": "model_1.mar"
    },
   {
      "modelName": "model_2",
      "modelUrl": "model_2.mar"
    }
  ]
}

[bigswede74]

@harshbafna Thanks for the help.

[harshbafna]

@harshbafna So I can just clear out this folder to get back to a good state?

Yes. Or if you don’t want to use snapshot feature, just use --ncs to disable it while starting TorchServe 😃