Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Update API usage log calls in ops

See original GitHub issue

As we discuss in API usage logging policy(#5052), torchvision.ops needs to be updated to include calls in all class constructors. Currently there are calls on all methods. For example, logging is triggered for roi_align, but we also need log call for RoIAlign.

Issue Analytics

State:
Created 2 years ago
Comments:10 (10 by maintainers)

Top GitHub Comments

3reactions

datumboxcommented, Dec 9, 2021

@kazhang Thanks for raising issues. If you add more info here to make the ticket self-explanatory without requiring reading other issues and potentially provide an example of how to fix RoiAlign in code, we will be able to tag it as “good first issue” and ask for the help of the community. Usually it takes a bit more effort to write detailed descriptions so that new contributors with no context on Vision can help.

Also tagging a bunch of regulars in case they have the bandwidth to help: @frgfm @oke-aditya @zhiqwang @xiaohu2015 😃

2reactions

frgfmcommented, Dec 9, 2021

Happy to help 👍 But I would need some clarification if possible:

in the example of RoIAlign, considering it calls roi_align (cf. https://github.com/pytorch/vision/blob/4cacf5a19f68f6b6483c758e3ac95d1dd9b6194c/torchvision/ops/roi_align.py#L84), do we want to only add an additional log call when RoIAlign.forward is used?
or we want to disable the underlying call from the functional API, and only have a log call for the module API?