[v0.12] Release Tracker
See original GitHub issueWe cut a release branch for the 0.12 release.
This issue is for tracking cherry-picks to the release branch. The POC for the TorchVision team is @jdsgomes
Cherry-Pick Criteria
Phase 1 (until 02/17/22):
Only low-risk changes may be cherry-picked from master:
- Fixes to regressions against the most recent minor release (e.g. 0.11 for 0.12 release);
- Critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks
- Fixes to new features introduced in the most recent minor release (e.g. 0.11 for 0.12 release)
- Test/CI fixes
- Documentation improvements
- Compilation fixes or ifdefs required for different versions of the compilers or third-party libraries
- Release branch specific changes (e.g. change version identifiers)
Phase 2 (after 02/17/22):
Note that changes here require us to rebuild a Release Candidate and restart extended testing (likely delaying the release). Therefore, the only accepted changes are Release-blocking critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks
Changes will likely require a discussion with the larger release team over VC or Slack.
Cherry-Pick Process
-
Ensure your PR has landed in master. This does not apply for release-branch specific changes (see Phase 1 criteria).
-
Create a PR against the release branch.
# Find the hash of the commit you want to cherry pick # (for example, abcdef12345) git log git fetch origin release/0.12 git checkout release/0.12 git cherry-pick abcdef12345 # Submit a PR based against 'release/1.12' either: # via the GitHub UI git push my-fork # via the GitHub CLI gh pr create --base release/1.12
-
Make a request below with the following format:
Link to landed master PR (if applicable):
*
Link to release branch PR:
*
Criteria Category:
*
- the POC will reply with approved / denied or ask for more information.
- If approved, the PR can be merged once the tests pass.
NOTE: Our normal tools (ghstack / ghimport, etc.) do not work on the release branch.
Please note HUD Link with branch CI status and link to the HUD to be provided here. HUD
Versions
0.12
Issue Analytics
- State:
- Created 2 years ago
- Comments:7 (7 by maintainers)
Top GitHub Comments
Link to landed main PR: https://github.com/pytorch/vision/pull/5472 Link to release branch PR: https://github.com/pytorch/vision/pull/5474
Criteria Category: 2 Critical fix (class should not be exposed at package level)
New cherrypick
Link to landed master PR: https://github.com/pytorch/vision/pull/5427 Link to release branch PR: https://github.com/pytorch/vision/pull/5434
Criteria Category: 4 fix for tests