Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

add_axes and create_axes_marker problems

See original GitHub issue

pyvista.Plotter.add_axes allows passing a marker_args which allows to pass parameters to pyvista.create_axes_marker. There are a few issues currently:

create_axes_marker isn’t included in the documentation
marker_args cannot contain parameters that are already allowed in add_axes, e.g. add_axes(marker_args={'line_width': 6}) is not allowed.

I propose the the following items to address these problems:

add create_axes_marker to documentation
allow **kwargs in add_axes and deprecate marker_args. Pass kwargs to create_axes_marker.

Issue Analytics

State:
Created a year ago
Comments:7 (7 by maintainers)

Top GitHub Comments

2reactions

MatthewFlammcommented, Sep 30, 2022

Yes, thank you! Please ask questions if you need help at any point.

1reaction

MatthewFlammcommented, Oct 6, 2022

There is no hard requirement on branch name as we can tag appropriately after the PR is opened. You should open the PR from a branch on your fork of pyvista to the main branch of pyvista. If you want to follow PyVista branch naming convention, you can read here: https://docs.pyvista.org/extras/developer_notes.html#branch-naming-conventions