question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Need to rename or deprecate `overwrite` method

See original GitHub issue

https://github.com/pyvista/pyvista/blob/7ca5c227f9111dd1c280da06a3959e37ec047541/pyvista/core/dataset.py#L2016

The overwrite method is a PyVista-specific method that many of our users have found valuable. This previously had no equivalent upstream in VTK, but now, the overwrite method is used upstream in VTK after 9.2 for a different use case. Every class in VTK, as of 9.2, now has an overwrite method for overwriting the implementation of the Python class. This creates a clash where PyVista might incorrectly change the behavior of VTK and e.g., vtk.vtkPolyData.overwrite != pyvista.PolyData.overwrite

I am working on some upstream tooling that will later be inherited by PyVista, where this overwrite method is critical.

In summary, the name of this method needs to change because:

  1. It clashes with an upstream VTK method as of 9.2
  2. It will be used for a different mechanism in PyVista at a later date

What should this method be renamed to?

I don’t have any good ideas for a new name of this method, but we need to change it as soon as possible with a deprecation notice so that it doesn’t conflict with VTK 9.2 for too long.

Issue Analytics

  • State:closed
  • Created a year ago
  • Reactions:1
  • Comments:9 (9 by maintainers)

github_iconTop GitHub Comments

2reactions
MatthewFlammcommented, Aug 12, 2022

I also like copy_from in fact I like it better than overwrite.

2reactions
adeakcommented, Aug 8, 2022

Also pinging @pyvista/developers because the more the merrier and there might be some who don’t monitor issues nor slack.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Deprecations On Overriding Method - java - Stack Overflow
Since it's a preference, you can change it. Just go to "Window -> Preferences", then select "Java -> Compiler -> Errors/Warnings". Scroll down ......
Read more >
Overriding and Hiding Methods (The Java™ Tutorials ...
Instance Methods​​ The overriding method has the same name, number and type of parameters, and return type as the method that it overrides....
Read more >
If you need to change or update your Apple ID payment method
On iPhone, a message says Remove Payment Method. Update your payment method on your Mac. Open the App Store. Click your name or...
Read more >
Rename refactorings | IntelliJ IDEA Documentation - JetBrains
Use the Rename refactoring to change names of symbols, files, directories, packages, modules and all the references to them throughout code.
Read more >
What is @Override? Fix method does not override ... - YouTube
What is the @ Override annotation? What methods do I put it on? How do I fix " method does not override or...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found