Need to rename or deprecate `overwrite` method
See original GitHub issueThe overwrite
method is a PyVista-specific method that many of our users have found valuable. This previously had no equivalent upstream in VTK, but now, the overwrite
method is used upstream in VTK after 9.2 for a different use case. Every class in VTK, as of 9.2, now has an overwrite
method for overwriting the implementation of the Python class. This creates a clash where PyVista might incorrectly change the behavior of VTK and e.g., vtk.vtkPolyData.overwrite != pyvista.PolyData.overwrite
I am working on some upstream tooling that will later be inherited by PyVista, where this overwrite
method is critical.
In summary, the name of this method needs to change because:
- It clashes with an upstream VTK method as of 9.2
- It will be used for a different mechanism in PyVista at a later date
What should this method be renamed to?
I don’t have any good ideas for a new name of this method, but we need to change it as soon as possible with a deprecation notice so that it doesn’t conflict with VTK 9.2 for too long.
Issue Analytics
- State:
- Created a year ago
- Reactions:1
- Comments:9 (9 by maintainers)
Top GitHub Comments
I also like
copy_from
in fact I like it better thanoverwrite
.Also pinging @pyvista/developers because the more the merrier and there might be some who don’t monitor issues nor slack.