load_account UserWarning should have stacklevel=2

When load_account is ran twice, a warning is triggered:

The last line in the message, is a bit confusing because looks like an incomplete duplication. I suggest to use warnings.warn('Credentials are already in use. The existing account in the session will be replaced.', stacklevel=2), so the error would look like this:

[ajavadia]

Yes that would be great thanks!

On Oct 9, 2019, at 5:16 AM, Diego M. Rodríguez [e-mail] wrote:

@ajavadia the use of warning has been essentially carried over from the times where load_account was introduced - at that point in time, it was deemed preferable to use a warning instead of logger.warning on the grounds that it would be “more visible to users”; and it sort of stuck as the usual philosophy for the provider for similar messages and context.

Personally I also feel more comfortable with a plain logger.warning and placing a bit more trust on the users being slightly more familiar with the logging facilities - does your comment count as having your green light for adopting that approach? 🤞

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[diego-plan9]

@ajavadia the use of warning has been essentially carried over from the times where load_account was introduced - at that point in time, it was deemed preferable to use a warning instead of logger.warning on the grounds that it would be “more visible to users”; and it sort of stuck as the usual philosophy for the provider for similar messages and context.

Personally I also feel more comfortable with a plain logger.warning and placing a bit more trust on the users being slightly more familiar with the logging facilities - does your comment count as having your green light for adopting that approach? 🤞