Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

GraphOptimizationApplication, single responsibility principle

See original GitHub issue

What is the expected enhancement?

the static method random_graph in the GraphOptimizationApplication violates the single responsibility principle. Please create some helper and move it there.

Issue Analytics

State:
Created 2 years ago
Comments:5 (5 by maintainers)

Top GitHub Comments

1reaction

woodsp-ibmcommented, Jul 9, 2021

In Aqua there used to be module to allow building of various random problems inputs. This is probably a left-over from that after Aqua was split apart and refactored into these separate repos. I see in coverage its not tested and I cannot find any uses here in this repo via search. Since its just single line call to a networkx function, and since its neither used nor tested here, my reaction would be that it could be simply deleted.

0reactions

t-imamichicommented, Jul 12, 2021

What kind of helper file do you want?

Top Results From Across the Web

Single-Responsibility Principle

The single-responsibility principle is a computer-programming principle that states that every module, class or function in a computer program should have ...

Single Responsibility Principle in Java - Baeldung

As the name suggests, this principle states that each class should have one responsibility, one single purpose. This means that a class will...

The Single Responsibility Principle | Nerd For Tech - Medium

The single responsibility aka SRP sets that every software component should have one and only one responsibility. This component can be a class,...

Single-responsibility principle - Wikipedia

The single-responsibility principle (SRP) is a computer programming principle that states that "A module should be responsible to one, and only one, actor....

SOLID Definition – the SOLID Principles of Object-Oriented ...

The Single Responsibility Principle (SRP) The idea behind the SRP is that every class, module, or function in a program should have one...