multi layered entity inheritance not supported by JpaRepository

Describe the bug Imagine a simple JpaRepo:

public interface ExampleRepo extends JpaRepository<ExampleEntity, Long> {
    Optional<ExampleEntity> findByNameAndId(String name, Long id);
}

Now dependending on the amount of layers between ExampleEntity and the definition of id, this repository works or doesn’t work:

• works:

@MappedSuperclass public abstract class Base1 { @Id Long id; }
@Entity public class ExampleEntity extends Base1 { String name; }

• doesn’t work:

@MappedSuperclass public abstract class Base1 { @Id id }
@MappedSuperclass public abstract class Base2 extends Base1 { }
@Entity public class ExampleEntity extends Base2 { String name; }

Expected behavior

• id - property is found by JpaReposiory, regardless of hierarchy size.

Actual behavior

• build error io.quarkus.spring.data.deployment.UnableToParseMethodException: Entity ExampleEntity does not contain a field named: Id. Offending method is findByNameAndId
  • repo looks for property Id (note the uppercase “i”) instead of id

To Reproduce See archive: entity_hierarchy_demonstrator.zip

Environment (please complete the following information):

• Output of uname -a or ver: win 10
• Output of java -version: 11
• GraalVM version (if different from Java): /
• Quarkus version or git rev: 1.8.3.Final
• Build tool (ie. output of mvnw --version or gradlew --version): Apache Maven 3.6.3

/cc @famod

[geoand]

Thanks for the contribution!

It will most likely be part of Quarkus 1.9.1

[famod]

I found the problem and might be able to create a PR on sunday evening.

But in case you @aureamunoz want to do it here is the root cause: This is wrong: https://github.com/quarkusio/quarkus/blob/1.8.3.Final/extensions/spring-data-jpa/deployment/src/main/java/io/quarkus/spring/data/deployment/MethodNameParser.java#L590

For each loop it calls this:

ClassInfo superClass = indexView.getClassByName(entityClass.superName());

but entityClass never changes. This is correct:

ClassInfo superClass = indexView.getClassByName(superClassType.name());

(also leading to a simplification further down)

/cc @geoand