Reactive Health Check DOWN after update to 1.7.0.Final

Describe the bug Health check for reactive is returning DOWN 2020-08-21 15:52:22,132 INFO [io.sma.health] (vert.x-worker-thread-0) SRHCK01001: Reporting health down status: {“status”:“DOWN”,“checks”:[{“name”:“SmallRye Reactive Messaging”,“status”:“DOWN”,“data”:{“kafka-connector”:“[KO]”}},{“name”:“SmallRye Reactive Messaging”,“status”:“DOWN”,“data”:{“kafka-connector”:“[KO]”}}]}

Expected behavior Return UP

To Reproduce Check the readme in my project below: https://github.com/ivanjunckes/reactive-health-bug

Environment (please complete the following information):

• Output of uname -a or ver: Darwin MacBook-Pro-de-Ivan.local 19.6.0 Darwin Kernel Version 19.6.0: Sun Jul 5 00:43:10 PDT 2020; root:xnu-6153.141.1~9/RELEASE_X86_64 x86_64
• Output of java -version: openjdk version “11.0.8” 2020-07-14 OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.8+10) OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.8+10, mixed mode)
• Quarkus version or git rev: 1.7.0.Final

[jeffhubLR]

Note for others that come to this issue. quarkus.reactive-messaging.health.enabled=false is evaluated at build-time, so a config overlay will not have the expected result.

[xstefank]

@ivanjunckes

Also, the message appears duplicated as you can see the comparison below:

Please see https://github.com/smallrye/smallrye-reactive-messaging/issues/690. The duplication is caused by the call to /health where both liveness and readiness checks are included. If you change the path to /health/live (or /health/ready) you will see only one check. The names will be fixed in the next release.

so this feature of adding SmallRye Reactive Messaging looks to be introduced in the 1.7.0.Final. I am wondering if this is the correct behavior, it seems to me that enabling this by default is wrong

You are adding a dependency on quarkus-smallrye-reactive-messaging-kafka which represents a reactive messaging connector to Kafka so I think it makes sense to fail the check if the connection to Kafka is not established. Otherwise, this dependency can be removed. Changing the dependency from

    <dependency>
      <groupId>io.quarkus</groupId>
      <artifactId>quarkus-smallrye-reactive-messaging-kafka</artifactId>
    </dependency>

to

    <dependency>
      <groupId>io.quarkus</groupId>
      <artifactId>quarkus-smallrye-reactive-messaging</artifactId>
    </dependency>

so just removing -kafka at the end makes the test pass because now we are not adding the dependency on Kafka connector but only on reactive messaging itself. Hopefully, this explains everything 😃