question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Smallrye Reactive Messaging MetricDecorator disabled when micrometer extension is used

See original GitHub issue

Describe the bug

I noticed that the MetricDecorator is vetoed in case Micrometer is enabled https://github.com/quarkusio/quarkus/blob/main/extensions/smallrye-reactive-messaging/deployment/src/main/java/io/quarkus/smallrye/reactivemessaging/deployment/SmallRyeReactiveMessagingProcessor.java#L346

Which is strange since there is an adapter layer for Eclipse Profile Metrics available.

Expected behavior

The expected behavior would be to keep the decorator even if Micrometer is used (Or even better use a decorator with Micrometer 😃 )

Actual behavior

MetricDecorator is disabled

https://github.com/quarkusio/quarkus/blob/main/extensions/smallrye-reactive-messaging/deployment/src/main/java/io/quarkus/smallrye/reactivemessaging/deployment/SmallRyeReactiveMessagingProcessor.java#L330

How to Reproduce?

Use a project with Kafka Reactive Messaging and enable the property

quarkus.reactive-messaging.metrics.enabled=true

Add Micrometer extension https://quarkus.io/guides/micrometer.

Check metrics is available in a QuarkusTest

given().when()
    .get("/q/metrics")
    .then()
    .statusCode(200)
    .body(containsString("base_mp_messaging_message_count_total{channel=\"receiver-channel\"}"));

Will fail

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:7 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
cescoffiercommented, Nov 7, 2021

Fixed with SmallRye Reactive Messaging 3.11 (which is not included in Quarkus).

0reactions
ebullientcommented, Oct 8, 2021

https://github.com/smallrye/smallrye-reactive-messaging/pull/1448 – is a beginning. I think there is a config question and a test question

Read more comments on GitHub >

github_iconTop Results From Across the Web

Advanced Configuration - SmallRye Reactive Messaging
Both MicroProfile and Micrometer publisher metrics are enabled by default if found on the classpath. They can be disabled with smallrye.messaging.metrics.mp.
Read more >
Using HTTP with Reactive Messaging - GitHub Pages
This guide demonstrates how your Quarkus application can utilize SmallRye Reactive Messaging to consume and produce HTTP messages.
Read more >
Apache Kafka Reference Guide - Quarkus
It is used commonly for high-performance data pipelines, streaming analytics, data integration ... quarkus extension add 'smallrye-reactive-messaging-kafka'.
Read more >
SmallRye Reactive Messaging - Apache Camel
Usage. This extension leverages SmallRye Reactive Messaging. Examples for how to use the Camel connector are outlined within the documentation.
Read more >
[reactive-messaging] Disable channel - Google Groups
To unsubscribe from this group and stop receiving emails from it, send an email to smallrye+u...@googlegroups.com. To view this discussion on the web...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found