Support DB Optional Properties in Service Binding pkg

Description

When connecting DB with JDBC, the user is allowed to append optional properties to customize the connection, e.g.:jdbc:postgresql://localhost:5432/postgres?sslfactory=abc.def&prepareThreshold=1000, but this is currently not supported by Quarkus Service Binding Extension.

This is to propose that Service Binding Extension reads an options file, if it is present, under the directories in SERVICE_BINDING_ROOT. The file content is “key=val” pair and concatenate with ‘&’. e.g. sslfactory=class.path&prepareThreshold=1000.

Implementation ideas

Each database converter can format the optional properies accordingly. Postgresql as an example: https://gist.github.com/myeung18/9a9a7dca09fca9050afd99a8cbfe81bf

[geoand]

I don’t understand what difference does it make to Service Binding client if those options are client specific or not.

It means that it doesn’t make sense for the operator to provide values for these, because each consumer (that is each client that consumes that service - a DB for example) has different needs and therefore needs to set different settings to match it’s own unique access characteristics.

[myeung18]

I’m wondering about the security implication of passing the trust store in the SBO. Basically, it’s almost a “trust-all”. I understand why we could desire to do that, but provisioning certs is a very sensible operation.

Then, what about mTLS (I’m not sure PG supports it), how would you pass the client certs in this case?

In case we have this question is because I included those certificate related options in the example, we don’t actually have plan nor any use case to do any key management over SBO. Maybe someone else can answer the question.