Unable to override config properties for Isolates running in native mode

Describe the bug The code, that relies on Isolates running in Native image is unable to catch overridden config properties (either passed as command line arguments when launching native executable or overriding properties with QuarkusTestResourceLifecycleManager in Native tests). It seems Isolates use the values of properties that are effective at image build time and do not override them in runtime.

Expected behavior Isolates use the values of properties that are effective at runtime (as Native-image code without isolates does).

Actual behavior Isolates use the values of properties that are effective at build time and do not override at runtime.

To Reproduce

	public int readPropertyValue() {
		var params = CreateIsolateParameters.getDefault();
		var isolateThread = Isolates.createIsolate(params);

		try {
			return processInIsolate(isolateThread);
		}
		finally {
			Isolates.tearDownIsolate(isolateThread);
		}

	}

	@CEntryPoint
	private static int processInIsolate(@CEntryPoint.IsolateThreadContext IsolateThread isolateThread) {
		int propertyToOverride = ConfigProvider.getConfig().getValue("property.to.override", Integer.class);
		System.out.println("property.to.override: " + propertyToOverride);

		return propertyToOverride;
	}

Demo app, reproducing the bug

https://github.com/AndreiYu/isolates-native-image-testing-bug/blob/master/src/native-test/java/com/example/config/NativeTest.java

Steps to reproduce the behavior:

1. run ./gradlew testNative for demo app

Configuration

# Add your application.properties here, if applicable.

quarkus:
  package:
    type: native
  native:
    native-image-xmx: 12g

property:
  to:
    override: 0

Screenshots (If applicable, add screenshots to help explain your problem.)

Environment (please complete the following information):

• Output of uname -a or ver: Darwin MacBook-Pro.local 20.2.0 Darwin Kernel Version 20.2.0: Wed Dec 2 20:39:59 PST 2020; root:xnu-7195.60.75~1/RELEASE_X86_64 x86_64
• Output of java -version:
• GraalVM version (if different from Java): 20.2.0.r11-grl
• Quarkus version or git rev: 1.10.5.Final
• Build tool (ie. output of mvnw --version or gradlew --version): gradle 6.5.1

Additional context (Add any other context about the problem here.)

[zakkak]

@zakkak Do you have any opinion on this one? I don’t have any test app for that.

@Karm @AndreiYu this is a GraalVM issue, I opened https://github.com/oracle/graal/issues/4238 to track it.

[AndreiYu]

We made a workaround - CustomRuntimeConfigSource that has higher ordinal than System properties and Environment Variables

https://quarkus.io/guides/config-extending-support#example

Isolates are unable to see changes of system properties (since they have a snapshot of Image Heap at build or start time of native executable), but isolate refreshes env_variable changes with CustomRuntimeConfigSource with ordinal 500 and evaluates them at change. Here is a snippet of code:

@StaticInitSafe public class RuntimeEnvConfigSource implements ConfigSource {

@Override
public Map<String, String> getProperties() {
	return System.getenv();
}

@Override
public Set<String> getPropertyNames() {
	return System.getenv().keySet();
}

@Override
public int getOrdinal() {
	return 500;
}

@Override
public String getValue(String name) {
	if (name == null) {
		return null;
	}

	// exact match
	var data = System.getenv();
	String value = data.get(name);
	if (value != null) {
		return value;
	}

	// replace non-alphanumeric characters by underscores
	String sanitizedName = replaceNonAlphanumericByUnderscores(name);
	value = data.get(sanitizedName);
	if (value != null) {
		return value;
	}

	// replace non-alphanumeric characters by underscores and convert to uppercase
	return data.get(sanitizedName.toUpperCase());
}

@Override
public String getName() {
	return RuntimeEnvConfigSource.class.getSimpleName();
}

}