Vert.x Routes Wrong Behaviour when using hyphens (-) in params

Describe the bug When using a route with param names that includes hyphen characters:

@Route(methods = HttpMethod.GET, path = "/path/:my-param")
boolean myRoute(@Param("my-param") String param) {
    return true;
}

If we call our route, we will get a HTTP 404 Not Found error.

Now, if we change our route to get rid of hyphens:

@Route(methods = HttpMethod.GET, path = "/path/:myParam")
boolean myRoute(@Param("myParam") String param) {
    return true;
}

Everything works fine now.

Expected behavior If there is a strong technical reason to not support hyphens, this should be documented. However, I think it should be supported. And for sure, not return HTTP Not Found 404 status.

Actual behavior It returns HTTP Not Found 404 status.

Environment (please complete the following information):

• Quarkus version or git rev: 1.12.0.Final

[pmlopes]

Hi @Sgitario The issue here was that vert.x was not allowing the - symbol to be part of a variable name as it used a regular expression that mimicks the java variable naming rules. I’ve created a PR to address this and allow it:

:([A-Za-z][A-Za-z0-9_-]*)

A variable must start with a letter and have a sequence of letters, numbers or _ and -. I guess the rule could be even more relaxed to support more characters but as it gets more complex it may also introduce a parsing tax on performance.

[mkouba]

Ok, I misunderstood the concept of path parameters. My understanding was that a path param always represents a path segment. A subtle clarification in the docs would be helpful 😉.