querydsl-sql : Joda time should be optional

I am using Java 8 so I don’t want Joda time in my classpath. Indeed it messes with the imports: if I want to use a java.time.LocalDate, I have to be careful not to import org.joda.time.LocalDate.

Currently if I try to exclude Joda time from my classpath, I cannot initialize Querydsl because in JavaTypeMapping, the CalendarType is registered and it depends on Joda time. Moreover:

• still in JavaTypeMapping, Joda time types are registered,
• the Configuration class is final and reference JavaTypeMapping, so there is no way around.

In a first step, the modifications that needs to be done are:

• Refactor AbstractDateTimeType to remove the Joda time dependency,
• In JavaTypeMapping, do the joda time initialization the same way java 8 types are registered,
• Mark joda time as optional in the pom.xml 😃

If that is ok, I can do the change. However, it is a breaking change: libraries and projects depending on querydsl-sql and using joda time will have to explicitly add joda time in their pom.xml, gradle etc. So the version on which this development will be made has to be decided.

[janneri]

Spring Boot will autoconfigure a formatter when joda-time is in classpath. The formatter wants a newer version of joda-time than querydsl. So to me, the joda-time dependency seems pretty useless in 2020 and it’s causing problems. I would greatly appreciate this fix!

p.s. Declaring joda-time as a dependency is a trivial fix. I wouldn’t worry about this as a breaking change.

[Neikius]

Spring Boot will autoconfigure a formatter when joda-time is in classpath. The formatter wants a newer version of joda-time than querydsl. So to me, the joda-time dependency seems pretty useless in 2020 and it’s causing problems. I would greatly appreciate this fix!

p.s. Declaring joda-time as a dependency is a trivial fix. I wouldn’t worry about this as a breaking change.

Same here. Please take the joda-time out.