[Dialog] Closing controlled dialog does not return focus properly

Bug report

Current Behavior

When closing the Dialog via <kbd>Escape</kbd>, focus correctly restores to the trigger. However, if you activate and close the Dialog via a keybind, for example, closing the Dialog does not seem to restore focus anywhere. Even global event listeners on window do not work.

Here’s an example:

• Open and close via click and Escape, works fine
• Open via ⌘K, listeners work while it’s open
• Close via ⌘K, listeners stop working entirely
• Click on the body, listeners start working again

https://user-images.githubusercontent.com/34928425/106521620-bd165d00-649b-11eb-8c81-0718829016bb.mov

Expected behavior

Focus should be restored to the body (or the trigger? not sure) in a way such that global window listeners still work. I’m not even sure how it’s possible that it doesn’t work right now.

Reproducible example

https://codesandbox.io/s/infallible-curie-8gkof?file=/src/App.tsx

Suggested solution

Change the way focus is restored on unmount

Additional context

N/A

Your environment

Software	Name(s)	Version
Radix Package(s)	dialog	0.0.5
React	n/a
Browser	n/a
Assistive tech	n/a
Node	n/a
npm/yarn	n/a
Operating System	n/a

[benoitgrelard]

I’m going to investigate this a little more, thanks for bringing this up @raunofreiberg!

[pacocoursey]

Confirmed that it’s working now, thanks!