Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Slider] onValueCommit not being called properly

See original GitHub issue

Bug report

Sometimes the onValueCommit prop is not being called properly when moving the thumb.

Current Behavior

When moving the thumb sometimes the onValueCommit prop is not called.

Expected behavior

To always call the onValueCommit prop when the user stops sliding

Reproducible example

I’m using the same example from the documentation.

https://user-images.githubusercontent.com/13953703/200179160-12c1437c-1a3f-4c91-bcc7-6ef191ca45d7.mov

Your environment

Software	Name(s)	Version
Radix Package(s)	slider	1.1.0
React	n/a	18.2
Browser	chrome	107.0.5304.87 (Official Build) (arm64)
Assistive tech
Node	n/a
npm/yarn
Operating System	macOS	Version 13.0

Issue Analytics

State:
Created 10 months ago
Comments:12

Top GitHub Comments

1reaction

benoitgrelardcommented, Nov 7, 2022

Ok, well that shows it has nothing to do with the iframe, thanks. However, I’m still struggling to reproduce it or understand how you are doing it 😀

One thing to note is that onValueCommit will only trigger is the value has actually changed, but from what I can see (although tricky with just watching a video) it looks like you are changing it.

Could you try logging the value you receive in onValueCommit and also logging the value in onValueChange and reproduce?

0reactions

bukinoshitacommented, Nov 7, 2022

This is definitely odd, but I was able to reproduce after a couple of tries.

Ventura 13
Chrome 107.0.5304.87 (Official Build) (x86_64)

https://user-images.githubusercontent.com/6929565/200378479-11b5671d-1808-4a3e-8337-ca24295cc1b6.mp4

Top Results From Across the Web

Slider OnValueChanged not being called in 2019.3.0f5

Using Unity 2019.3.0f5. Slider UI components are not calling OnValueChanged from the inspector (both dynamic and static) but they are when I ...

Slider - Radix UI

Slider. An input where the user selects a value from within a given range. ... for each thumb when used within a form...

Slider control is not working properly - Stack Overflow

I want to change textblock value depending on the slider value each time I change it. But it shouldn't ...

Slider Not Working !!! Trick to Handle ANY Slider - YouTube

If a slider is not working or you don't know how to properly initialize a slider then this video is for you. Almost...

refactor: Pure FC with multiple update - react-component/slider

click mark to update range value; handleRender; Fix handle with count not correct ... primitives [Slider] onValueCommit not being called properly 12 open...