Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

"module" attribute in package.js broke things?

See original GitHub issue

Version

Tell us which versions you are using:

react-google-charts 1.5.2 react v15.4.2

Latest version added a "module": "es/index.js", in commit https://github.com/RakanNimer/react-google-charts/commit/33d2874c3c40675160851a0ce0961a6b03c6a09b which seems to have broken things. When building with Webpack2 I get "export 'Chart' was not found in 'react-google-charts'. I can’t find any docs on the “module” attribute, but it seems reasonable that it would force loading es/index.js, but I’m unsure why?

Issue Analytics

State:
Created 7 years ago
Comments:6 (3 by maintainers)

Top GitHub Comments

1reaction

dvdplmcommented, Mar 2, 2017

1.5.2 did not just include that fix

@OracPrime are you sure that it’s reasonable to expect releases to contain only one fix? I think not. Sure, this release was buggy but bugs happen to the best of us and this one was fixed very quickly. 😃

1reaction

OracPrimecommented, Mar 1, 2017

I may have missed the point here, but my understanding is that 1.5.1 had a licensing issue. I submitted a PR which fixed the licensing issue. 1.5.2 did not just include that fix but an “experimental” fix from yourself?

Top Results From Across the Web

setting "type" to "module" in package.json then not able to ...

I resolved it adding a package.json in the server folder scope with { "type": "module" } and removing that property from the main ......

Modules: Packages | Node.js v19.3.0 Documentation

json (e.g. require('your-package/package.json') . This will likely be a breaking change. To make the introduction of "exports" non-breaking, ensure that every ...

ds300/patch-package: Fix broken node modules instantly ‍♀️

fix a bug in one of your dependencies vim node_modules/some-package/brokenFile.js # run patch-package to create a .patch file npx patch-package some-package ...

How To Use Node.js Modules with npm and package.json

To make things easier, npm provides the init command. This is an interactive command that asks you a series of questions and creates...

package.json - npm Docs

Then include a file named <filename> at the top level of the package. Some old packages used license objects or a "licenses" property...