Make the Kubernetes Settings page more consistent when any setting changes
See original GitHub issueProblem Description
Currently changes to some of the settings are deferred: a blue box appears at the bottom specifying that the cluster must be reset for the change to take effect. Others, namely the container-runtime and enable-k8s checkboxes, trigger a yes/no dialog box, and if the user chooses ‘yes’ the cluster is immediately reset.
The enable-traefik
lives in its own world, involving neither the blue-box nor an immediate change.
All the changes should go through the delayed blue-box.
For one thing, it’s currently impossible to go in one step from (k8s-on, moby) to (k8s-off, containerd).
Proposed Solution
All desired changes in the K8s Settings page are reflected in the blue box at the bottom of the screen, and don’t take effect until the user either presses the “Reset Kubernetes” button or shuts the app down and restarts it.
Preflight Checklist
- I have searched the issue tracker for a feature request that matches the one I want to file, without success.
Issue Analytics
- State:
- Created 2 years ago
- Reactions:1
- Comments:7 (7 by maintainers)
+1 on the notification being out of the way and an unnoticeable color +1 on that this page shouldn’t have scroll bars
I’m not sure if we need a modal dialog to change these though. But changes should be additive (like switching engines and kubernetes on/off at the same time), and the UI should be consistent.
I never liked the solution of using alerts at the bottom of the page or the pattern of Reseting Kubernetes to apply changes. I feel like this page has also grown to encompass more than just Kubernetes Settings… Perhaps, we can be more intentioned with our change and reintroduce our discussion of redesigning this section?