null values and addConcreteSettersForOptional

I find that addConcreteSettersForOptional uses Optional#of instead of Optional#ofNullable quite surprising especially since Intellij IDEA by default doesn’t warn against passing nulls to javax.validation.constraints.NotNull annotated parameters. What is the reasoning behind this decision?

[Randgalt]

Can we pause this discussion for a bit please? When I get some more time I’ll look into this deeper. I feel confident there’s a good solution here that can meet everyone’s needs.

[Randgalt]

@Randgalt it doesn’t even make since to have methods with javax.validation.constraints (your gist you shared on reddit showing full builder) unless you immediately call the validator. In fact the requireNonNull on justAString is wrong

Wrong is a loaded term here. As I recall we were trying to emulate what the Immutables library does and, again as I recall, it treats any non-null-like annotation as implying a null check. The goal of the library is utility so while it may not conform to a particular spec it does conform to those who wish to migrate from the Immutables library. If there’s a strong desire to conform to a different spec that can be done via another option but I’d like to see a community desire for this.