Update ByteBuddy from 1.8.22 to 1.9.15

Hi @raphw

I’m trying to update the ByteBuddy Version to 1.9.15 in Stagemonitor.

As mentioned in #470 the method asDecorator is removed but if i understand it right, there is no need to call asDecorator anymore. Problem, without calling asDecorator the instrumention doesn’t work anymore 😦.

AgentAttacher.java#L211-L228

private static ClassFileTransformer initByteBuddyClassFileTransformer(AutoEvictingCachingBinaryLocator binaryLocator) {
		AgentBuilder agentBuilder = createAgentBuilder(binaryLocator);
		for (StagemonitorByteBuddyTransformer transformer : getStagemonitorByteBuddyTransformers()) {
			agentBuilder = agentBuilder
					.type(transformer.getMatcher())
					.transform(transformer.getTransformer())
					.asDecorator();
		}


		final long start = System.currentTimeMillis();
		try {
			return agentBuilder.installOn(instrumentation);
		} finally {
			if (corePlugin.isDebugInstrumentation()) {
				logger.info("Installed agent in {} ms", System.currentTimeMillis() - start);
			}
		}
	}

As i’m a absoulte newbie on BuddyBuddy and not find the right information in the documentation and now i hope you can give me an advice?

[raphw]

Alright, I found the problem. I (unintentionally) reversed the transformer application order in Byte Buddy 1.9.0. I do not want to undo this now, 1.9.0 has been around for a while. I will now also add a test for retaining this application order.

If you reverse the order in the comparator in AgentAttacher (line 287) while updating to 1.9.*, everything should work as expected.

[raphw]

It’s probably a small thing, I can have a look tomorrow!