file_smart_open missing mode 'rb' caused error

Line 668 in def file_smart_open(fname, mode='rb', encoding=None, errors=DEFAULT_ERRORS) in smart_open_lib.py

try:  # TODO need to fix this place (for cases with r+ and so on)
        raw_mode = {'r': 'rb', 'w': 'wb', 'a': 'ab'}[mode]
except KeyError:
        raw_mode = mode

Should include r+ cases. Otherwise, when mode == ‘rb’, this will cause KeyError

[menshikh-iv]

I tried to reproduce this (for py27 and py36 versions), but I see no bug, everything is working fine.

versions:

smart-open==1.5.5
gensim==3.2.0

import gensim.downloader as api

model = api.load("glove-twitter-25")
model.most_similar("hello")  # works fine


# save model
model.save("input_model.p")

# load without mmap
loaded_model = model.load("input_model.p")
loaded_model.most_similar("hello")  # works fine


# load with mmap
loaded_model = model.load("input_model.p", mmap="r")
loaded_model.most_similar("hello")  # works fine

For this reason, I close this issue.

[cosmoschen94]

I was trying to load a pickle file from my local file system by using model = KeyedVectors.load('input_model.p', mmap='r') and then KeyError was caught, which prevents me from loading the model