Mark default action of `TwoStageFallbackPolicyAction` as deprecated
See original GitHub issueDue to the introduction of the RulePolicy
the TwoStageFallbackPolicy
is deprecated. The TwoStageFallbackPolicy
uses a couple of default actions:
action_revert_fallback_events
- ~
action_default_ask_affirmation
~ (can be kept, used by newTwoStageFallback
) - ~
action_default_ask_rephrase
~ (can be kept, used by newTwoStageFallback
)
We don’t need them to deprecate them in the code as the policies which are using these actions are already deprecated.
Todos:
- update documentation for
default-actions
to reflect that the actions from above are deprecated - Leave a comment in each of these actions in the code that they are deprecated and can be removed once the
TwoStageFallbackPolicy
is removed. - rename
two_stage_fallback
action toaction_two_stage_fallback
Issue Analytics
- State:
- Created 3 years ago
- Comments:11 (10 by maintainers)
Top Results From Across the Web
How to mark a method as obsolete or deprecated?
The shortest way is by adding the ObsoleteAttribute as an attribute to the method. Make sure to include an appropriate explanation:
Read more >How to make a method deprecated in C#? - Tutorialspoint
The Obsolete Attribute marks elements like classes, methods, ... [Obsolete] − is a no parameter constructor and is a default using this ...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
yes of course!
thanks for taking this on @musa-atlihan 🙏 We’ll review your PR in the coming days
@wochinge just a sanity check: do we rase a deprecation warning saying that
TwoStageFallbackPolicy
will be removed in 3.0?