question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Mark default action of `TwoStageFallbackPolicyAction` as deprecated

See original GitHub issue

Due to the introduction of the RulePolicy the TwoStageFallbackPolicy is deprecated. The TwoStageFallbackPolicy uses a couple of default actions:

  • action_revert_fallback_events
  • ~action_default_ask_affirmation~ (can be kept, used by new TwoStageFallback)
  • ~action_default_ask_rephrase~ (can be kept, used by new TwoStageFallback)

We don’t need them to deprecate them in the code as the policies which are using these actions are already deprecated.

Todos:

  • update documentation for default-actions to reflect that the actions from above are deprecated
  • Leave a comment in each of these actions in the code that they are deprecated and can be removed once the TwoStageFallbackPolicy is removed.
  • rename two_stage_fallback action to action_two_stage_fallback

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:11 (10 by maintainers)

github_iconTop GitHub Comments

1reaction
wochingecommented, Sep 28, 2020

yes of course!

We don’t need them to deprecate them in the code as the policies which are using these actions are already deprecated.

1reaction
m-vdbcommented, Sep 23, 2020

thanks for taking this on @musa-atlihan 🙏 We’ll review your PR in the coming days

@wochinge just a sanity check: do we rase a deprecation warning saying that TwoStageFallbackPolicy will be removed in 3.0?

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to mark a method as obsolete or deprecated?
The shortest way is by adding the ObsoleteAttribute as an attribute to the method. Make sure to include an appropriate explanation:
Read more >
How to make a method deprecated in C#? - Tutorialspoint
The Obsolete Attribute marks elements like classes, methods, ... [Obsolete] − is a no parameter constructor and is a default using this ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found