cleanup results in impossible to debug EBADF error if file descriptor is already closed

Operating System

• Linux
• Windows 7
• Windows 10
• MacOS
• other:

NodeJS Version

• 14.12

Tmp Version

0.2.1

Expected Behavior

safely handle cleanup for streams even if the file descriptor is already closed.

Experienced Behavior

<rejected> [Error: EBADF: bad file descriptor, close] {
    errno: -9,
    code: 'EBADF',
    syscall: 'close'
  }

import { createWriteStream } from 'fs';
import { pipeline } from 'stream';
import _tmp from 'tmp';
import { promisify } from 'util';

const ppipeline = promisify(pipeline);

function tmpFile(options = {}) {
    options = Object.assign(options, { dir: 'blah' });

    return new Promise((resolve, reject) => {
        _tmp.file(options, (err, path, fd, cleanup) => {
            if (err) {
                reject(err);
            } else {
                resolve({ path, fd, cleanup });
            }
        });
    });
}

async function tmpFileStream(options) {
    const { path, fd, cleanup } = await tmpFile(options),
        stream = createWriteStream(path, { fd });

    return {
        path,
        stream,
        // this causes unhanded promise exceptions EBADF: bad file descriptor
        cleanup
    };
}

async main() {
    const streams = [],
        temporary = await tmpFileStream({ postfix: `archive.${archiver.config.format}` });

   streams.pipeline(/*useless empty stream that's paused*/, temporary.stream);
   /*aborted useless stream - which cshould/does trigger all other streams to close (because of pipeline)*/
   temporary.cleanup(); // generated a nasty error in its own stack that's untracable
}

main();

[silkentrance]

@benjamingr thank you for your invaluable contribution, I really appreciated this!

[silkentrance]

@benjamingr I invited you to this in order for @rijnhard to realize that there is the detachDescriptor option, which seems to be lost on @rijnhard. Maybe we should work on the existing documentation to make it more clear.