Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Feature] Support for Pytorch-lightning 1.5.0

See original GitHub issue

Search before asking

I had searched in the issues and found no similar feature requirement.

Description

As of Pytorch-lightning 1.5.0

https://github.com/PyTorchLightning/pytorch-lightning/blob/49d09aa28b4bdde7a272c3e77dc3f13613802672/CHANGELOG.md#150---2021-11-02

The property running_sanity_check in the Trainer class has been deprecated in favor of sanity_checking as of 1.5.0 as linked above. This property is used in the following lines which I have been patching to support 1.5.0

https://github.com/ray-project/ray/blob/3b77840c1b6daf8d008350460ec4ca7c3df830db/python/ray/tune/integration/pytorch_lightning.py#L177

https://github.com/ray-project/ray/blob/3b77840c1b6daf8d008350460ec4ca7c3df830db/python/ray/tune/integration/pytorch_lightning.py#L231

Is there any plan to support 1.5.0+? I am not sure what the preferences are as far as dealingl with backcompatibility otherwise could submit a PR.

I tried searching about this although from the changelog above the complete deprecation of the property was just released in packages of just a few weeks ago.

Use case

Support for using the newer versions of pytorch-lightning .

Related issues

No response

Are you willing to submit a PR?

Yes I am willing to submit a PR!

Issue Analytics

State:
Created 2 years ago
Comments:5 (4 by maintainers)

Top GitHub Comments

1reaction

dynamicwebpaigecommented, Mar 15, 2022

Would it make sense to close this issue, given that #20562 is now merged?

We might also want to reach out to the prob-ml/bliss team to reintroduce their Ray dependency, as it looks like they might have been blocked on Lightning support.

0reactions

amogkamcommented, Apr 11, 2022

Yes this can be closed- Ray Tune supports PTL 1.5 as of #20562!

Top Results From Across the Web

Releases · Lightning-AI/lightning - GitHub

Build and train PyTorch models and connect them to the ML lifecycle using Lightning App templates, without handling DIY infrastructure, cost management, ...

LightningModule - PyTorch Lightning - Read the Docs

It is recommended that you install the latest supported version of PyTorch to use this feature without limitations. See also the torch.jit documentation...

PyTorch Lightning

The ultimate PyTorch research framework. Scale your models, without the boilerplate.

pytorch-lightning - PyPI

PyTorch Lightning is the lightweight PyTorch wrapper for ML researchers. ... Lightning has over 40+ advanced features designed for professional AI research ...

PyTorch Lightning 1.5 Released - Exxact Corporation

Earlier this month, PyTorch Lightning 1.5 became available, and it's a big update! It introduces support for LightningLite, Fault-tolerant ...