Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[logging] Use 'warnings.warn' appropriately

See original GitHub issue

Describe your feature request

Throughout our codebase, we don’t use warnings.warn and rather rely on logger.warn to inform users of possible negative outcomes.

Instead, we should use warnings.warn appropriately:

https://docs.python.org/2/howto/logging.html#when-to-use-logging

Issue Analytics

State:
Created 3 years ago
Reactions:2
Comments:9 (6 by maintainers)

Top GitHub Comments

1reaction

richardliawcommented, Dec 12, 2020

yep!

On Fri, Dec 11, 2020 at 2:24 PM Shril Kumar notifications@github.com wrote:

Hi, @richard4912 https://github.com/richard4912 can I go ahead with the PR for this issue? I’ll document the requirements and list of file changes once you give me a green signal.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ray-project/ray/issues/12060#issuecomment-743458753, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCRZZPEVBLTENHEMQ6HWXTSUKLYTANCNFSM4TYD7MVA .

0reactions

scottsun94commented, Nov 1, 2022

@ofey404 Do you want to work on it?