question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Dialog] Dependencies update

See original GitHub issue

Enhancement

@reach/dialog internally relies on a react-focus-lock dependency library, which was recently updated to a new version 2.5.1. There was an existing performance issue with this library and it’s dependency focus-lock in the previous version.

They’ve found it, improved on it and it has upgraded overall performance of the focus lock feature. Just wanted to point that out and try to get this dependency bumped, rather sooner than later, thank you.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:5 (4 by maintainers)

github_iconTop GitHub Comments

2reactions
theKasheycommented, Jun 6, 2021

That was really a very internal change not affecting external behavior at all, but in the same time greatly decreasing complexity of Lock activation. Look like changelog is a little outdated yet again - manually rebuilt and pushed changes.

What you are looking for:

  • react-focus-lock > 2.5.1 (just updating dependency)
  • or focus-lock > 0.9.0 (source of the fix)

The actual change can be found here - https://github.com/theKashey/focus-lock/pull/24

1reaction
chaancecommented, Jun 6, 2021

Are there any breaking changes that you know of? Don’t see an updated CHANGELOG for either react-focus-lock or focus-lock libs, no github release notes, and am not 100% clear what I need to look for here. cc @theKashey

Read more comments on GitHub >

github_iconTop Results From Across the Web

Add to Project and Update Dependencies Dialog Box - NI
This dialog box appears when you open the block diagram of a VI in the LabVIEW project and add a subVI from disk...
Read more >
Add Dependencies Dialog - Advanced Installer
This dialog displays the selected file's module dependencies with options to add these modules in the package. You can include/exclude dependencies from ...
Read more >
Dialog asking "Update Dependencies from package.json ...
I quit. I restart IntelliJ. My project opens. Then this mysterious message panel appears in the lower left corner of IntelliJ window, asking: ......
Read more >
View and update task dependencies (links) across projects
After dependencies are updated, you can filter your tasks to show only those that have external dependencies. Note: Your project schedule is not...
Read more >
Dialogs - Android Developers
A dialog is a small window that prompts the user to make a decision or enter additional information.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found