question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Next/Previous month position styling is not applied when passing a custom icon

See original GitHub issue

react-dates version react-dates@18.4.1

Describe the bug When passing custom arrows, the position styling is not applied. In previous versions (I’m upgrading from 16.x to 18.4.1, so I’m not sure how far back this changed) the custom icon would still have the position set to the same as the default arrow icons. This would be less of an issue if there was a good way to select the individual DayPickerNavigation_button divs, but the only way that I could select them individually was with :nth-of-type. Also, if I position the icons themselves, I lose the focus states that the DayPickerNavigation_button divs handle, and if I also handle that myself, the tab index gets thrown off.

Source code (including props configuration) This issue can be seen in the Storybook Documentation Example for custom icons

Screenshots/Gifs Storybook Documentation Example for custom icons

Desktop (please complete the following information):

  • OS: Mac OS X
  • Browser: Chrome
  • Version 71

Smartphone (please complete the following information):

  • Device: NA
  • OS: NA
  • Browser NA
  • Version NA

Is the issue reproducible in Storybook? Storybook Documentation Example for custom icons

Issue Analytics

  • State:open
  • Created 5 years ago
  • Reactions:1
  • Comments:6 (3 by maintainers)

github_iconTop GitHub Comments

10reactions
Kvekcommented, May 19, 2022

Is there an update on this issue?

3reactions
derekaspauldingcommented, Feb 6, 2019

@ljharb It looks like the change happened in the 17.0.0 release. There was another slight change with the 17.2 release, and that is still the current behavior. I removed all my other custom styles and took some screenshots of the different versions

16.7.1 - This version is good dates-bug-16 7 1

17.0.0 - 17.1.1 dates-bug-17 1 1

17.2.0 - 18.5.0 dates-bug-latest

Read more comments on GitHub >

github_iconTop Results From Across the Web

Next/Previous month position styling is not applied when ...
When passing custom arrows, the position styling is not applied. In previous versions (I'm upgrading from 16.x to 18.4.1, so I'm not sure...
Read more >
HTML custom (not Font-Awesome) icon class not working
Simple method is to, use content . Don't use background. #search { width: 100%; position: relative; } .searchTerm { float: left; width: 100% ......
Read more >
ion-input: Custom Input Value Type Styling and CSS Properties
ion-input is a wrapper to the HTML input element, with custom value type styling and functionality. It works on desktops and integrates with...
Read more >
react-multi-carousel - npm
Production-ready, lightweight fully customizable React carousel component that rocks supports multiple items and SSR(Server-side rendering) ...
Read more >
https://edd.newmexico.gov/wp-content/plugins/premi...
Not just that, we have added Draw Icon option in all premium widgets that has ... 4.9.25 = - Fixed: Copy/Paste element styling...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found