Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`onFileDialogCancel` doesn't fire on Firefox on Mac

See original GitHub issue

Do you want to request a feature or report a bug?

I found a bug
I want to propose a feature

What is the current behavior? onFileDialogCancel doesn’t fire on Firefox on Mac

If the current behavior is a bug, please provide the steps to reproduce.

Open this codepen on FF on Mac: https://codepen.io/florantara/pen/1645ab3e5a88cad0b35fc5a5cc045750?editors=1111
Click the “Add img” button
Click “Cancel” on the file dialog

It should log to the console but it doesn’t.

What is the expected behavior? It should fire the event and log to the console.

Please mention other relevant information such as the browser version, Operating System and react-dropzone version.

version 11.2.4
macOS Catalina
Firefox 82.0.3

Issue Analytics

State:
Created 3 years ago
Reactions:1
Comments:8

Top GitHub Comments

1reaction

rolandjitsucommented, Nov 22, 2020

Hmm … I definitely see the cb called, but it’s not called when you’d expect. It looks like it’s called only when you focus out and back on the window.

I think this is due to the hacky way we handle this dialog cancel. Because we expect the app window to be out of focus when the dialog is shown, but it seems like Firefox works differently.

Not sure how we could fix this without adding some other hacks. I’m open to suggestions.

0reactions

rolandjitsucommented, Feb 5, 2022

Closed by https://github.com/react-dropzone/react-dropzone/commit/3ad4f007d70401e1d9adbc93ba2dfd69cc8c2a27. This is the best I could do for now.