Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

issue: API Breakage on FieldErrors

See original GitHub issue

Version Number

7.33.1

Codesandbox/Expo snack

Compile error, so no code sandbox is available.

Steps to reproduce

I am building out a set of Typescript React components (based on react-hook-form and react-bootstrap). The source code for this library is at:

https://github.com/craigmcc/shared-react

With react-hook-form 7.30.0, everything was fine. With react-hook-form 7.33.1, I get compile errors trying to build the library (see the “Relevant Log Output” section below).

It looks like changes to the FieldErrors definition is what is triggering this.

TO REPRODUCE:

Download the GItHub module mentioned above.
Run “npm install” to install the listed dependencies.
Run “npm install react-hook-form@7.33.1” to get the version that causes the problem.
Run “npm build” and see the compile errors (shown in the “Relevant log output” section below).

Expected behaviour

No compile errors.

What browsers are you seeing the problem on?

Chrome

Relevant log output

COMPILE OUTPUT:
==============

MacBook-Pro:shared-react craigmcc$ npm run build

> @craigmcc/shared-react@1.2.1 build
> tsc -p .

src/SelectField/SelectField.tsx:71:17 - error TS2322: Type 'Merge<FieldError, FieldErrorsImpl<DeepRequired<any>>> | undefined' is not assignable to type 'ReactNode'.
  Type 'Merge<FieldError, FieldErrorsImpl<DeepRequired<any>>>' is not assignable to type 'ReactNode'.
    Type 'Merge<FieldError, FieldErrorsImpl<DeepRequired<any>>>' is missing the following properties from type 'ReactPortal': key, children, type, props

71                 {props.errors[props.name]?.message}
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  node_modules/@types/react/index.d.ts:1374:9
    1374         children?: ReactNode | undefined;
                 ~~~~~~~~
    The expected type comes from property 'children' which is declared here on type 'IntrinsicAttributes & Omit<Pick<DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>, "key" | keyof HTMLAttributes<...>> & { ...; }, BsPrefixProps<...> & FeedbackProps> & BsPrefixProps<...> & FeedbackProps & { ...; }'

src/TextField/TextField.tsx:66:17 - error TS2322: Type 'Merge<FieldError, FieldErrorsImpl<DeepRequired<any>>> | undefined' is not assignable to type 'ReactNode'.

66                 {props.errors[props.name]?.message}
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  node_modules/@types/react/index.d.ts:1374:9
    1374         children?: ReactNode | undefined;
                 ~~~~~~~~
    The expected type comes from property 'children' which is declared here on type 'IntrinsicAttributes & Omit<Pick<DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>, "key" | keyof HTMLAttributes<...>> & { ...; }, BsPrefixProps<...> & FeedbackProps> & BsPrefixProps<...> & FeedbackProps & { ...; }'


Found 2 errors in 2 files.

Errors  Files
     1  src/SelectField/SelectField.tsx:71
     1  src/TextField/TextField.tsx:66