Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`T extends string` is causing type check errors for setValue

See original GitHub issue

Describe the bug if we have type T extends string for value then setValue(name, value); is giving Type error:

TS2345: Argument of type 'T | undefined' is not assignable to parameter of type '(T extends NestedValue<infer U> ? U : UnpackNestedValue<DeepPartial<LiteralToPrimitive<T>>>) | undefined'.
   Type 'T' is not assignable to type '(T extends NestedValue<infer U> ? U : UnpackNestedValue<DeepPartial<LiteralToPrimitive<T>>>) | undefined'. 
    Type 'string' is not assignable to type '(T extends NestedValue<infer U> ? U : UnpackNestedValue<DeepPartial<LiteralToPrimitive<T>>>) | undefined'.
       Type 'T' is not assignable to type 'T extends NestedValue<infer U> ? U : UnpackNestedValue<DeepPartial<LiteralToPrimitive<T>>>'.
         Type 'string' is not assignable to type 'T extends NestedValue<infer U> ? U : UnpackNestedValue<DeepPartial<LiteralToPrimitive<T>>>'.

seems that as soon as you extend on primitive type you go down the UnpackNestedValue here:

TFieldValue extends NestedValue<infer U>
      ? U
      : UnpackNestedValue<DeepPartial<LiteralToPrimitive<TFieldValue>>>

Why you don’t change implementation to?

  setValue<TFieldName extends string, TFieldValue extends TFieldValues[TFieldName]>(
    name: TFieldName,
    value: TFieldValue,
    options?: SetValueConfig,
  ): void;

To Reproduce try this example:

import {useFormContext} from 'react-hook-form';

type SelectFieldProps<T> = {
  name: string;
  value?: T;
};

export function SelectField<T extends string>({name, value}: SelectFieldProps<T>): void {
  const {setValue} = useFormContext();

  useEffect(() => {
    setValue(name, value);
  }, [name, setValue, value]);
}

Expected behavior I don’t expect any type errors here