platform-ios run iOS getProductName broken in xCode 12

Description

xCode 12 is escaping equal signs in the build output that is parsed here, this regex will not match the new format:

https://github.com/react-native-community/cli/blob/7238b2057b9c5004b46c01854ea05a61e4a3a3d1/packages/platform-ios/src/commands/runIOS/index.ts#L444

Example of the relevant line in xCode 12 build output:

export FULL_PRODUCT_NAME\=AppName.app

Current Regex: /export FULL_PRODUCT_NAME="?(.+).app"?$/m Working Regex: /export FULL_PRODUCT_NAME\\?="?(.+).app"?$/m

[nathell]

I’m also hitting this.

Additional quirk is, in my case, the FULL_PRODUCT_NAME contains an exclamation mark. Which means that even if the regex is replaced as suggested by @fuchstim, it won’t work for me, because Xcode actually outputs

export FULL_PRODUCT_NAME\=Example\!.app

(note the \!) when the app is actually named Example!.

So the proper solution would need to unescape all backslash-escaped characters, not just the \=. Or, better yet, to call out to the shell, since this is Bourne shell syntax:

sh -c 'export FULL_PRODUCT_NAME\=Example\!.app; echo ${FULL_PRODUCT_NAME%.app}'
Example!

(Not sure how to do this, since I’m not a Node person).

As a local workaround, I’ve monkey-patched node_modules/@react-native-community/cli-platform-ios/build/commands/runIOS/index.js and edited getProductName (lines 339–342) to read:

function getProductName(buildOutput) {
  const productNameMatch = /export FULL_PRODUCT_NAME\\?="?(.+).app"?$/m.exec(buildOutput);
  return productNameMatch ? productNameMatch[1].replace(/(?:\\(.))/g, '$1') : null;
}

[WilbertJanney]

I opted to link the images from the Images.xcassets package in iOS to fix the images missing in IPA problem for now until the script issue is fixed.