Consider renaming the app_name to match the RN template and simplify the diff

Feature Request

Currently the diff is made between an RN app named RnDiffApp and the RN template which has a different app_name/DisplayName of Hello App Display Name. When upgrading this shows as 2 additional diffs that are IMO not necessary, see the SS:

I propose we handle this name discrepancy so that it doesn’t show up in the diff.

Why it is needed

Every upgrade shows at least 2 diffs that will (always?) be ignored. This unnecessarily increases the cognitive load for each upgrade.

Possible implementation

I thought the change would be as simple as running react-native init „Hello App Display Name” but the projectName does not allow spaces. One solution that comes to mind is replacing RnDiffApp (which is a fairly specific string) with Hello App Display Name. However I’m not sure if we want to add this to the workflow.

Another option would be to submit a patch directly to https://github.com/facebook/react-native/tree/master/template and change the name to something like HelloWorld. This doesn’t feel right, though 😃

Let me know if this makes sense and if you have better options on how to handle this.

[lucasbento]

@rszalski: we added a small comment on the files explaining that this change must be ignored, it’s currently being tracked at react-native-community/cli#561 as mentioned before and as soon as it’s fixed on the CLI we will update the diff and remove the note.

Again, thank you for opening this issue.

[lucasbento]

This is related to react-native-community/cli#561.