Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Diff doesn't show section changes / misleads on where changes appear

See original GitHub issue

Bug

As screen in this screenshot, the context for the !debug.keystone change shows under the "# IntelliJ" section which is quite misleading. By looking at the line numbers you may notice that they are not linear - there is a jump from line 25 to 39. However there is no notice of this, so the context lines appears together with the wrong section header.

Since some changes are context sensitive, it may cause problems for people while upgrading. In this particular example (.gitignore) the context isn’t important beyond readability and future upgrade diffs.

React Native versions

0.60.6 => 0.61.2

Steps to reproduce

Open https://react-native-community.github.io/upgrade-helper/?from=0.60.6&to=0.61.2
Scroll down to the diff of .gitignore
See that “Android/IntelliJ” appears as the header for the Buck ignore changes.

Describe what you expected to happen: There should be a visual divider or other visual clue when line numbers increment more than 1.

Issue Analytics

State:
Created 4 years ago
Comments:12 (11 by maintainers)

Top GitHub Comments

4reactions

KevinHu2014commented, Oct 10, 2019

@lucasbento Is it something like this?

3reactions

pviniscommented, Oct 14, 2019

Thank you @KevinHu2014! @scarlac you should be able to see this very soon, it is being built and deployed.

Top Results From Across the Web

git diff does not show new file

Since the new file is not tracked by git when you created it, the git had no way to identify what has changed....

Pull request diff - show actual diff instead of commit changes

It shows all the changes in commits in "Files" tab instead of what is actualy different between the branches.

Git diff Command – How to Compare Changes in Your Code

You can run git diff <commit_hash> <commit_hash> the command to compare the changes between two commits. Like branch comparison, order does ...

Track changes in Word

When Track Changes is on, the section is highlighted. Deletions are marked with a strikethrough, and additions are marked with an underline. Different...

Git - git-diff Documentation

This form is to view the changes you made relative to the index (staging area for the next commit). In other words, the...