getSerialNumberSync api error?

Bug report

when android SDK < 26, getSerialNumberSync() always return “unknown”?

 public String getSerialNumberSync() {
     try {
       if (Build.VERSION.SDK_INT >= 26) {
         if (getReactApplicationContext().checkCallingOrSelfPermission(Manifest.permission.READ_PHONE_STATE) == PackageManager.PERMISSION_GRANTED) {
           return Build.getSerial();
         }
       }
     } catch (Exception e) {
       // This is almost always a PermissionException. We will log it but return unknown
       System.err.println("getSerialNumber failed, it probably should not be used: " + e.getMessage());
     }
     return "unknown";
   }

Environment info

react-native info output:

# "react-native": "0.62.2",
# "react-native-device-info": "^5.5.7",

[stewartmcgown]

In case someone stumbles across this from Google and is in the same very specific sitation:

Add this topatches/react-native-device-info+7.0.2.patch:

--- a/node_modules/react-native-device-info/android/src/main/java/com/learnium/RNDeviceInfo/RNDeviceModule.java
+++ b/node_modules/react-native-device-info/android/src/main/java/com/learnium/RNDeviceInfo/RNDeviceModule.java
@@ -655,6 +655,8 @@
         if (getReactApplicationContext().checkCallingOrSelfPermission(Manifest.permission.READ_PHONE_STATE) == PackageManager.PERMISSION_GRANTED) {
           return Build.getSerial();
         }
+      } else {
+        return Build.SERIAL;
       }
     } catch (Exception e) {
       // This is almost always a PermissionException. We will log it but return unknown

Grab these two packages:

"patch-package": "^6.2.2",
"postinstall-postinstall": "^2.1.0",

Then add a postinstall script:

"scripts": {
   ...,
  "postinstall": "patch-package"
}

[M45ter]

this is better?

if (Build.VERSION.SDK_INT >= 26) {
...
} else {
     return Build.SERIAL;
}