question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Huawei Mate 20 PRO has notch - but identified as a phone without notch

See original GitHub issue

Bug

We are trying to detect whether a phone has a notch but the library returns false to the hasNotch method in case of the Huawei Mate 20 PRO

Environment info

React native info output:

 // React Native Environment Info:
   System:
     OS: macOS 10.14.5
     CPU: (8) x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
     Memory: 88.87 MB / 16.00 GB
     Shell: 3.2.57 - /bin/bash
   Binaries:
     Node: 8.11.4 - ~/.nvm/versions/node/v8.11.4/bin/node
     Yarn: 1.2.1 - /usr/local/bin/yarn
     npm: 6.4.1 - ~/.nvm/versions/node/v8.11.4/bin/npm
     Watchman: 4.7.0 - /usr/local/bin/watchman
   SDKs:
     iOS SDK:
       Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2
     Android SDK:
       API Levels: 19, 20, 21, 22, 23, 24, 25, 26, 27, 28
       Build Tools: 19.1.0, 20.0.0, 21.1.2, 22.0.1, 23.0.1, 23.0.2, 23.0.3, 24.0.0, 24.0.1, 24.0.2, 24.0.3, 25.0.0, 25.0.1, 25.0.2, 25.0.3, 26.0.0, 26.0.1, 26.0.2, 26.0.3, 27.0.0, 27.0.1, 27.0.2, 27.0.3, 28.0.0, 28.0.2, 28.0.3, 29.0.0
       System Images: android-16 | Google APIs Intel x86 Atom, android-19 | Google APIs Intel x86 Atom, android-22 | Google APIs Intel x86 Atom_64, android-23 | Google APIs Intel x86 Atom, android-24 | Intel x86 Atom_64, android-24 | Google APIs Intel x86 Atom_64, android-24 | Google Play Intel x86 Atom, android-25 | Google APIs ARM 64 v8a, android-25 | Google APIs Intel x86 Atom, android-26 | Google APIs Intel x86 Atom, android-27 | Google APIs Intel x86 Atom, android-27 | Google Play Intel x86 Atom, android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom
   IDEs:
     Android Studio: 3.4 AI-183.6156.11.34.5692245
     Xcode: 10.2.1/10E1001 - /usr/bin/xcodebuild
   npmPackages:
     react: 16.8.3 => 16.8.3
     react-native: 0.59.9 => 0.59.9

Library version: 2.2.2

Steps To Reproduce

  1. Connect Huawei Mate 20 PRO
  2. Run an app which uses the library
  3. Call the DeviceInfo.hasNotch method - which returns false

Describe what you expected to happen:

  1. We expect it TRUE as the phone has a notch

Hint: the DeviceInfo.getModel method returns the following model: LYA-L29 - could this be the issue?

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:13
  • Comments:5 (1 by maintainers)

github_iconTop GitHub Comments

1reaction
Taym95commented, Jul 24, 2019

I will try to debug this issue and send PR.

0reactions
mikehardycommented, Sep 10, 2020

@maduraherath8 Please make a pull request to add Huawei Y6P to the notch list

Read more comments on GitHub >

github_iconTop Results From Across the Web

Huawei Mate 20 PRO has notch - but identified as a phone ...
Bug We are trying to detect whether a phone has a notch but the library returns false to the hasNotch method in case...
Read more >
Huawei Mate 20 Pro review: The notch giveth, and ...
The notch allows Huawei to offer a marginally longer screen. But the notch is as wide as it is because underneath the facade...
Read more >
How to Hide Notch Display on HUAWEI Mate 20 Pro?, how to
First, you need to open the Play Store app, which can be located on your Home Screen or Main Menu. · Then, pick...
Read more >
Leak shows Huawei Mate 50 Pro and Mate 20 Pro notch ...
Leaked image shows notch comparison of Huawei Mate 50 Pro with Mate 20 Pro smartphone, showing that the phone will feature a wide...
Read more >
Huawei could release a phone with no bezels or notch in ...
Huawei has teased a handset which seemingly has a small hole in the screen, but no bezels or notch.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found