Return raw DeviceId value for iOS (at least)

Description

Current Implementation for DeviceInfo.getModel()

NSString* deviceName = [deviceNamesByCode objectForKey:self.deviceId];

    if (!deviceName) {
        // Not found on database. At least guess main device type from string contents:

        if ([self.deviceId rangeOfString:@"iPod"].location != NSNotFound) {
            deviceName = @"iPod Touch";
        }
        else if([self.deviceId rangeOfString:@"iPad"].location != NSNotFound) {
            deviceName = @"iPad";
        }
        else if([self.deviceId rangeOfString:@"iPhone"].location != NSNotFound){
            deviceName = @"iPhone";
        }
        else if([self.deviceId rangeOfString:@"AppleTV"].location != NSNotFound){
            deviceName = @"Apple TV";
        }
    }
    return deviceName;

Suggested Implementation:

 NSString* deviceName = [deviceNamesByCode objectForKey:self.deviceId];
  
  if (!deviceName) {
    // Not found in the list
    deviceName = self.deviceId;
  }
  
  return deviceName;

Use Case

When ever Apple releases new devices we have wait till this library is updated to get device model, currently we get only iPhone or iPad for new versions.

Better to return deviceId as default for new devices, which will be useful in analytics…

[rangav]

Yeah getDeviceId additional function is also good option for both platform.

[mikehardy]

FYI - here’s how I’m going to maintain the getModel/getDevice APIs for iOS going forward https://github.com/react-native-community/react-native-device-info/pull/618#issuecomment-479661030