ListItem backgroundColor persists after it's changed in the theme
See original GitHub issueIs there an existing issue for this?
- I have searched the existing issues
Explain what you did
Define a backgroundColor for ListItem.containerStyle
like below:
const rneTheme = createTheme({
components: {
ListItem: {
containerStyle: {
backgroundColor: background,
},
},
}
})
<ThemeProvider theme={rneTheme}>{children}</ThemeProvider>
Expected behavior
When the color in the theme changes, the backgroundColor
for ListItem
should change, but instead it persists in the old color.
Describe the bug
The backgroundColor
for ListItem
fails to update when the theme is updated. This can be easily tested in any setup that uses theming and defines separate colors for light
/dark
modes.
In our case, we noticed the issue occurred when toggling from light
to dark
, or the reverse. The color will remain as it was in the originally applied theme, never changing.
Steps To Reproduce
const rneTheme = createTheme({
components: {
ListItem: {
containerStyle: {
backgroundColor: background,
},
},
}
})
<ThemeProvider theme={rneTheme}>{children}</ThemeProvider>
And then use a ListItem
somewhere, and toggle dark/light mode in your app.
Screenshots
Light mode colors persist on ListItem
even in dark mode. If app is started in dark mode, then the problem is reversed.
Your Environment
`npx @rneui/envinfo`
```
System:
OS: Linux 5.15 Ubuntu 22.04.1 LTS 22.04.1 LTS (Jammy Jellyfish)
CPU: (4) x64 AMD Ryzen 7 5800X 8-Core Processor
Memory: 2.08 GB / 19.51 GB
Container: Yes
Shell: 5.8.1 - /usr/bin/zsh
Binaries: Node: 16.17.0 - ~/.nvm/versions/node/v16.17.0/bin/node Yarn: 1.22.19 - ~/.nvm/versions/node/v16.17.0/bin/yarn npm: 8.15.0 - ~/.nvm/versions/node/v16.17.0/bin/npm Watchman: 4.9.0 - /usr/bin/watchman Managers: Apt: 2.4.7 - /usr/bin/apt pip3: 22.2.2 - ~/.local/bin/pip3 Utilities: CMake: 3.22.1 - /usr/bin/cmake Make: 4.3 - /usr/bin/make GCC: 11.2.0 - /usr/bin/gcc Git: 2.38.1 - /usr/bin/git SDKs: Android SDK: API Levels: 31, 32, 33 Build Tools: 30.0.3, 31.0.0, 33.0.0 System Images: android-31 | Google APIs Intel x86 Atom_64, android-31 | Google Play Intel x86 Atom_64 IDEs: Nano: 6.2 - /usr/bin/nano VSCode: 1.68.1 - /usr/bin/code Languages: Bash: 5.1.16 - /usr/bin/bash Perl: 5.34.0 - /usr/bin/perl Python3: 3.10.6 - /usr/bin/python3 Databases: SQLite: 3.32.2 - /home/me/Android/Sdk/platform-tools/sqlite3 Browsers: Chrome: 106.0.5249.61 Firefox: 106.0 Monorepos: Yarn Workspaces: 1.22.19 Lerna: 5.6.2 ```
Issue Analytics
- State:
- Created a year ago
- Comments:7 (3 by maintainers)
Top GitHub Comments
Hey, I am working on it, will make a release as soon as it’s fixed.
4.0.0 will be available once few more critical issues are resolved.
@arpitBhalla thanks again for your help and great work!
Unfortunately I discovered the same issue with the buttons. See #3665.
PS, is there any ETA for the next release candidate version? I noticed they were coming out monthly, or even more frequently, but it’s been almost 3 months since the last release candidate. And is there any ETA for the final release of
4.0.0
?