makeStyles theme parameter typing is not accurate

Is there an existing issue for this?

• I have searched the existing issues

Explain what you did

const useStyles = makeStyles((theme) => ({
  root: {
    backgroundColor: theme.colors.white,
  },
});

 ... error ... theme.colors could possibly be undefined

Expected behavior

The theme param is Partial<FullTheme> however it appears that the colors property is always present. Param type should reflect this.

Describe the bug

Allow developers to assume full theme.colors.xxx set of values are present and defined.

Steps To Reproduce

See code above.

Screenshots

No response

Your Environment

Used the "bleeding edge" install instructions

* react-native-elements: 4.0.0-beta.0 (sometimes also referred to as 4.0.0-beta.1 during install)
* expo: 44.0.6
* typescript: 4.6.2

[mbyrne00]

@arpitBhalla - I have updated to the latest (rc2) version of this lib and when I call makeStyles like below I am still getting an error saying theme.colors is possibly undefined. I see you fixed the type within FullTheme to say colors is mandatory, but the makeStyles call still has theme: Partial<FullTheme>. I’m not sure why that should be Partial

const useStyles = makeStyles((theme) => ({
   root: {
       borderColor: theme.colors.primary,
   }
});

I can confirm that useTheme is returning the full theme now with colors being required.

[arpitBhalla]

Yes there would be always colors property, even if you don’t use ThemeProvider