Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

With Android device, once select "take photos" or "choose from library", App will crash ~!

See original GitHub issue

But on Genymotion simulator, everything is OK.

I captured the certain error, it seems there is conflict with react-native-navigation, but I don’t know which file I can modify to fix this issue.

error log:

FATAL EXCEPTION: mqt_native_modules
Process: com.aotumeeting, PID: 16467
java.lang.UnsupportedOperationException: NavigationActivity must implement OnImagePickerPermissionsCallback
at com.imagepicker.ImagePickerModule.permissionsCheck(ImagePickerModule.java:594)
at com.imagepicker.ImagePickerModule.launchCamera(ImagePickerModule.java:225)
at com.imagepicker.ImagePickerModule.launchCamera(ImagePickerModule.java:203)
at com.imagepicker.ImagePickerModule$2.onTakePhoto(ImagePickerModule.java:159)
at com.imagepicker.utils.UI$1.onClick(UI.java:54)

Issue Analytics

State:
Created 6 years ago
Comments:8 (3 by maintainers)

Top GitHub Comments

6reactions

aarontrankcommented, May 17, 2017

You either need to have NavigationActivity implement OnImagePickerPermissionsCallback or you need to modify ImagePickerModule to cast the activity to a PermissionAwareActivity instead of an OnImagePickerPermissionsCallback.

See PermissionAwareActivity line 576-597, Here’s the change I made:

else
{
  String[] PERMISSIONS = {Manifest.permission.WRITE_EXTERNAL_STORAGE, Manifest.permission.CAMERA};
  if (activity instanceof ReactActivity)
  {
    ((ReactActivity) activity).requestPermissions(PERMISSIONS, requestCode, listener);
  }
  else if (activity instanceof PermissionAwareActivity)
  {
    ((PermissionAwareActivity) activity).requestPermissions(PERMISSIONS, requestCode, listener);
  }
  else
  {
    final String errorDescription = new StringBuilder(activity.getClass().getSimpleName())
      .append(" must implement ")
      .append(PermissionAwareActivity.class.getSimpleName())
      .toString();
    throw new UnsupportedOperationException(errorDescription);
  }
  return false;
}

1reaction

mfekimcommented, Mar 6, 2018

Hi @aarontrank,

Thank you for your solution! I think we can just replace ReactActivity by PermissionAwareActivity since ReactActivity implements PermissionAwareActivity.

Current code

...
String[] PERMISSIONS = {Manifest.permission.WRITE_EXTERNAL_STORAGE, Manifest.permission.CAMERA};
if (activity instanceof ReactActivity)
{
  ((ReactActivity) activity).requestPermissions(PERMISSIONS, requestCode, listener);
}
else if (activity instanceof OnImagePickerPermissionsCallback)
{
  ((OnImagePickerPermissionsCallback) activity).setPermissionListener(listener);
  ActivityCompat.requestPermissions(activity, PERMISSIONS, requestCode);
}
else
{
  final String errorDescription = new StringBuilder(activity.getClass().getSimpleName())
          .append(" must implement ")
          .append(OnImagePickerPermissionsCallback.class.getSimpleName())
          .toString();
  throw new UnsupportedOperationException(errorDescription);
}
return false;
...

New solution

...
String[] PERMISSIONS = {Manifest.permission.WRITE_EXTERNAL_STORAGE, Manifest.permission.CAMERA};
if (activity instanceof PermissionAwareActivity)
{
  ((PermissionAwareActivity) activity).requestPermissions(PERMISSIONS, requestCode, listener);
}
else if (activity instanceof OnImagePickerPermissionsCallback)
{
  ((OnImagePickerPermissionsCallback) activity).setPermissionListener(listener);
  ActivityCompat.requestPermissions(activity, PERMISSIONS, requestCode);
}
else
{
  final String errorDescription = new StringBuilder(activity.getClass().getSimpleName())
          .append(" must implement ")
          .append(OnImagePickerPermissionsCallback.class.getSimpleName())
          .toString();
  throw new UnsupportedOperationException(errorDescription);
}
return false;
...