Focus system ignores disabled prop in touchables

Setting the disabled prop on touchables has no effect on the ability to focus the touchable. onPress is not triggered when the select button is pressed, as expected.

I wanted to try with RN’s Pressable component but it doesn’t look like we have merged 0.63 yet.

I am testing on android by the way, not sure if it happens on tvos. Decided to report here because it doesn’t look like RN core wants to support TV devices anymore.

React Native version:

System:
    OS: Linux 5.4 Ubuntu 18.04.5 LTS (Bionic Beaver)
    CPU: (8) x64 Intel(R) Core(TM) i7-4700HQ CPU @ 2.40GHz
    Memory: 242.80 MB / 15.52 GB
    Shell: 4.4.20 - /bin/bash
  Binaries:
    Node: 10.22.0 - /usr/bin/node
    Yarn: 1.21.1 - /usr/bin/yarn
    npm: 6.14.6 - /usr/bin/npm
    Watchman: 4.9.0 - /home/linuxbrew/.linuxbrew/bin/watchman
  SDKs:
    Android SDK: Not Found
  IDEs:
    Android Studio: Not Found
  Languages:
    Java: 11.0.8 - /usr/bin/javac
    Python: 2.7.17 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: ^16.13.1 => 16.13.1 
    react-native: Not Found
    react-native-tvos:  0.62.2-1 
  npmGlobalPackages:
    *react-native*: Not Found

Steps To Reproduce

1. Create an app with several touchables, some of them disabled
2. Cycle through the touchables with directional pad actions (up down left right)

Describe what you expected to happen: Expected the focus system to skip disabled touchables

Snack, code example, screenshot, or link to a repository:

import React from 'react'
import { View, TouchableOpacity, Text } from 'react-native'

const App = () => {
  return (
    <View>
      <TouchableOpacity hasTVPreferredFocus style={{ backgroundColor: '#000'}}>
        <Text style={{ color: '#fff'}}>Button 1</Text>
      </TouchableOpacity>
      <TouchableOpacity disabled style={{ backgroundColor: '#000'}}>
        <Text style={{ color: '#fff'}}>Button 2</Text>
      </TouchableOpacity>
    </View>
  )
}

export default App

[douglowder]

This is merged to the tvos-v0.63.1 release branch, and will be in the next 0.63 npm release.

[douglowder]

It will also work on Android if you set disabled to true, accessible to false… are you ok with that?