Upgrade to 0.66.2?

I just found out about react-native-tvos, but our project is based on rn 0.66.2. I wonder if it is possible to monorepo it or something, or an “easy” way to apply the current changes to newer RN branches… Or that’s actually “too different to reconcile”?

[miblanchard]

@douglowder - Thanks again for your great work with this.

[frankenthumbs]

i have an iteration of upgrading to 0.66.4 here: https://github.com/frankenthumbs/react-native-tvos/tree/tvos-v0.66.4 i’m stuck on running ./scripts/tvos-test.sh, most of the tests seems fine.

some of the color tests are failing (i believe its failing on this repo as well)

    ✗ testGenerateFallbacks, ((red1) equal to (red2)) failed: ("120") is not equal to ("255")
    ✗ testGenerateFallbacks, ((green1) equal to (green2)) failed: ("120") is not equal to ("255")
    ✗ testGenerateFallbacks, ((blue1) equal to (blue2)) failed: ("128") is not equal to ("255")
    ✗ testGenerateFallbacks, ((red1) equal to (red2)) failed: ("60") is not equal to ("0")
    ✗ testGenerateFallbacks, ((green1) equal to (green2)) failed: ("60") is not equal to ("0")
    ✗ testGenerateFallbacks, ((blue1) equal to (blue2)) failed: ("67") is not equal to ("0")
    ✗ testGenerateFallbacks, ((alpha1) equal to (alpha2)) failed: ("76") is not equal to ("102")
    ✗ testGenerateFallbacks, ((red1) equal to (red2)) failed: ("120") is not equal to ("255")
    ✗ testGenerateFallbacks, ((green1) equal to (green2)) failed: ("120") is not equal to ("255")
    ✗ testGenerateFallbacks, ((blue1) equal to (blue2)) failed: ("128") is not equal to ("255")
    ✗ testGenerateFallbacks, ((red1) equal to (red2)) failed: ("116") is not equal to ("255")
    ✗ testGenerateFallbacks, ((green1) equal to (green2)) failed: ("116") is not equal to ("255")
    ✗ testGenerateFallbacks, ((blue1) equal to (blue2)) failed: ("128") is not equal to ("255")
    ✗ testGenerateFallbacks, ((red1) equal to (red2)) failed: ("60") is not equal to ("0")
    ✗ testGenerateFallbacks, ((green1) equal to (green2)) failed: ("60") is not equal to ("0")
    ✗ testGenerateFallbacks, ((blue1) equal to (blue2)) failed: ("67") is not equal to ("0")
    ✗ testGenerateFallbacks, ((red1) equal to (red2)) failed: ("60") is not equal to ("0")
    ✗ testGenerateFallbacks, ((green1) equal to (green2)) failed: ("60") is not equal to ("0")
    ✗ testGenerateFallbacks, ((blue1) equal to (blue2)) failed: ("67") is not equal to ("0")
    ✗ testGenerateFallbacks, ((alpha1) equal to (alpha2)) failed: ("76") is not equal to ("102")
    ✗ testGenerateFallbacks, ((red1) equal to (red2)) failed: ("60") is not equal to ("0")
    ✗ testGenerateFallbacks, ((green1) equal to (green2)) failed: ("60") is not equal to ("0")
    ✗ testGenerateFallbacks, ((blue1) equal to (blue2)) failed: ("67") is not equal to ("0")
    ✗ testGenerateFallbacks, ((alpha1) equal to (alpha2)) failed: ("45") is not equal to ("51")
    ✗ testGenerateFallbacks, ((red1) equal to (red2)) failed: ("118") is not equal to ("255")
    ✗ testGenerateFallbacks, ((green1) equal to (green2)) failed: ("118") is not equal to ("255")
    ✗ testGenerateFallbacks, ((blue1) equal to (blue2)) failed: ("128") is not equal to ("255")

as well as the more concerning UI snapshot tests. I believe we need to get new snapshots of these tests but i’m not sure how the snapshots are taken:

    ✗ testLayoutExample, Test failed (NSInternalInconsistencyException)
    ✗ testScrollViewExample, Test failed (NSInternalInconsistencyException)
    ✗ testTextExample, Test failed (NSInternalInconsistencyException)
    ✗ testTVFocusGuideExample, RedBox errors: (
    ✗ testViewExample, Test failed (NSInternalInconsistencyException)

from the pngs found in react-native/packages/rn-tester/RNTesterIntegrationTests/ReferenceImages/RNTester-js-RNTesterApp.ios it seems like some of the views got upgraded:

screenshot taken from the app:

screenshot from main: https://github.com/frankenthumbs/react-native-tvos/blob/tvos-v0.66.4/packages/rn-tester/RNTesterIntegrationTests/ReferenceImages/packages-rn-tester-js-RNTesterApp.ios/testTextExample_1-iOS15_tvOS.png

gonna try integrating with our applications and see if everything is working there. But it would be nice to get the snapshot UI tests working as I know this is something Doug makes sure on every iteration