[Android] with 'fullscreen' property playback controls are missing

Bug

Tested 6.0.0-alpha4 and see the following issue:

On Android with ‘fullscreen’ property playback controls are missing. Tapping on the screen also does not cause the playback to appear.

If don’t use ‘fullscreen’ the controls are presented, BUT the player runs not in fullscreen mode (this is understandable by the “Switch to fullscreen mode” button). After clicking the “Switch to fullscreen mode” button, the fullscreen appears.

https://github.com/react-native-video/react-native-video/blob/master/API.md#controls - it says here that the ‘fullscreen’ property is applicable only for iOS. But as you can see, and for Android too.

Platform

Android (using Pixel 5a with Android 13)

Environment info

React native info output:

System:
    OS: macOS 12.6
    CPU: (6) x64 Intel(R) Core(TM) i5-8500 CPU @ 3.00GHz
    Memory: 31.04 MB / 24.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 18.8.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 8.5.5 - /usr/local/bin/npm
    Watchman: 2022.08.29.00 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.11.3 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.4, iOS 16.0, macOS 12.3, tvOS 16.0, watchOS 9.0
    Android SDK:
      API Levels: 28, 29, 30, 31
      Build Tools: 30.0.2, 30.0.3
      System Images: android-22 | Google APIs Intel x86 Atom_64, android-28 | Android TV Intel x86 Atom, android-30 | Intel x86 Atom_64, android-30 | Google TV Intel x86 Atom, android-30 | Google APIs Intel x86 Atom
      Android NDK: Not Found
  IDEs:
    Android Studio: Dolphin 2021.3.1 Dolphin 2021.3.1
    Xcode: 14.0/14A309 - /usr/bin/xcodebuild
  Languages:
    Java: 1.8.0_312 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.2.0 => 18.2.0
    react-native: 0.67.4 => 0.67.4
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Library version: 6.0.0-alpha4

Steps To Reproduce

1. Open the app
2. Tap on the video tile -> video player runs in fullscreen mode, playback controls are missing

Expected behaviour

Playback controls are presented

Reproducible sample code

        <View style={styles.container}>
            <Video
                source={{ uri: uri }}
                onProgress={handleProgress}
                onPlaybackRateChange={handlePlaybackRateChange}
                onEnd={handleEnd}
                controls={isNeedControls}
                pictureInPicture
                fullscreen
                fullscreenOrientation="landscape"
                style={StyleSheet.absoluteFill}
            />
        </View>

[freeboub]

@bulkinav I can confirm that last change broke this behavior. I didn’t expect someone do this… I will have a look in coming days.

[freeboub]

Has been merged, fix will be available on alpha.4