Pause video and clean up when unmounted

If you remove the video from a view, it keeps playing in the background. You can hear the audio playing, and it continues to occupy memory. It’s also evident if you do a JavaScript reload within the app while you’re debugging.

I can implement a quick and dirty fix by adding this to RCTVideo.m:

- (void)removeFromSuperview
{
    [super removeFromSuperview];
    [_player pause];
    [[NSNotificationCenter defaultCenter] removeObserver:self];
}

That stops the video from playing, but I don’t believe it’s really deleted the object, since dealloc doesn’t run and the memory graph continues to climb. So I’m sure there’s more work to be done here. I’d offer to make a pull request, but I don’t know Objective-C well enough to do it myself.

[kshahkshah]

@brentvatne okay, as far as I can tell, this is broken again. I have controls which let me navigate to the “next” video in a queue, and the old one keeps playing.

[CyxouD]

react-native: "0.61"
react-navigation: "4.0.10"

It was happening for me because of incorrect react-native-screens version, it should be react-native-screens@^1.0.0-alpha.23 (https://reactnavigation.org/docs/en/getting-started.html#installing-dependencies-into-a-bare-react-native-project)