React Native 0.60
See original GitHub issueI tried to install this library by according to the installation documentation and build with latest React Native v0.60, but errors occured on android. There are some breaking changes.
https://facebook.github.io/react-native/blog/2019/07/03/version-60
A Note to Library Maintainers
Changes for AndroidX will almost certainly require updates to your library, so be sure to include support soon. If you’re not able to upgrade yet, consider checking your library against the jetifier to confirm that users are able to patch your library at build time. Review the autolinking docs to update your configs and readme. Depending on how your library was previously integrated, you may also need to make some additional changes. Check the dependencies guide from the CLI for information on how to define your dependency interface.
Migrating from android.support
to androidx
Fix this library code or users need to patch the node_moduels by using jetifier. example:
// before
import android.support.annotation.Nullable
// after
import androidx.annotation.Nullable
Autolinking
https://github.com/react-native-community/cli/blob/master/docs/autolinking.md
yarn add react-native-webview cd ios && pod install && cd .. # CocoaPods on iOS needs this extra step # run yarn react-native run-ios yarn react-native run-android
These steps of the installation documentation cause build and runtime error by conflict with autolinking.
- 2.) In android/settings.gradle, includes WebRTCModule
- 3.) In android/app/build.gradle, add WebRTCModule to dependencies
- 4.) In android/app/src/main/java/com/xxx/MainApplication.java
No error occured on ios with Cocoapods, but it seems the ios steps also can be simpler.
Issue Analytics
- State:
- Created 4 years ago
- Comments:10 (7 by maintainers)
Top GitHub Comments
Please ignore the above comments, the errors were introduced by using Network inspect on React Native Debugger and were not related to
react-native-webrtc
.I’m not exactly sure how they’re related but
react-native-webrtc
is somehow breaking my HTTP API calls (fetch). If I removereact-native-webrtc
from my project, the requests work just fine but when I add it back, I getUnexpected token o in JSON at position 1
error on all of my fetch requests. I’m usingreact-native
0.60.3
. Should it be tracked here or should I create a new issue.