RTCView not displaying video stream

Hi all!

After upgrading RN to 0.46.4 I’m having an issue where RTCView is not displaying my local video stream.

I’m using react-native-webrtc master@ce5f05916c9a6ff2ef7572a3da3c72b4e2d63bb1, as the current release (1.58.1) does not work with newer RN versions.

To make it easier I’ve narrowed down my component to just the bare bones:

import React, { Component } from 'react';
import {
  StyleSheet,
  Text,
  View,
} from 'react-native';

import {
  RTCView,
  getUserMedia,
} from 'react-native-webrtc';

export default class TestVideoScreen extends Component {

  state = {
    localStream: null,
    localStreamUrl: null,
  };

  componentDidMount() {
    getUserMedia({
      audio: false,
      video: {
        mandatory: {},
        facingMode: 'environment',
      }
    },
      (stream => 
        this.setState({
          localStream: stream,
          localStreamUrl: stream.toURL()
        })),
      (error => console.error('getUserMedia failed with error: ' + error))
    );
  }

  render() {
    return (
      <View style={styles.container}>
        <Text>Local stream: {this.state.localStreamUrl}</Text>
        <RTCView 
          style={styles.videoFeed}
          streamURL={this.state.localStreamUrl} />
      </View>
    );
  }
}

const styles = StyleSheet.create({ 
  container: {
    flex:1,
    backgroundColor:'white',
  },
  videoFeed: {
    backgroundColor:'grey',
    flex:1,
    alignSelf:'stretch',
  },
});

Here’s what it looks like:

You can see that getUserMedia() is definitely working, as localStreamUrl has been set.

I’ve tried this both on an emulator and a real real device. 😃

Any help would be greatly appreciated!

Thanks,

Ben

[saghul]

@8BallBomBom Thanks a lot for the help locating the problem and testing! Landed a revert in https://github.com/oney/react-native-webrtc/commit/2e1532ec1bf5aa8c948325057772725a9764f7be

[bbrcan]

Thanks guys

@8BallBomBom As you suggested it seems that commit 057acf6 is the culprit here. I changed the line back to onLayout(false, getLeft(), getTop(), getRight(), getBottom()); and it worked straight away.