Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Support multi view instances like a browser

See original GitHub issue

Bug description: We are trying to make a simple browser using the module but I found some problems on iOS:

shouldStartLoadForRequest use a single lock condition. If 2 RNCWebview instances call the method, the previous call will always get YES with a warning “Did not receive response to shouldStartLoad in time, defaulting to YES”
createWebViewWithConfiguration will work incorrect in sites that need google or github login like https://app.gitbook.com/login. In the site, a parent window wants to create a child window (by window.open) for authentication, and then close it after login success (by window.close).

Issue Analytics

State:
Created 4 years ago
Comments:7

Top GitHub Comments

1reaction

CoreyBovalinacommented, Mar 25, 2020

@binhndicts is there an android solution to this? I have a link that has attribute target=“_blank” and it doesn’t work right in android, but fine in iOS.

1reaction

tmaly1980commented, Mar 15, 2020

@binhndicts Did you ever find a solution? I’d like to have a more universal fix for window.open/close as well. I can’t control third party sites that use popups (ie facebook login), and I don’t always have control over timing - sometimes window.open/close is put in <head>, which runs before any injected javascript is added. Ideally there’d be a way to intercept window.open/close calls with custom event handlers.