WebView redirects into iFrame on Android

Bug description:

WebView Component redirects into iFrame(s) when serving from static resources on Android. Used props are:

{
  source: {uri: 'file://<path/to/index.html>'}
  originWhitelist: ['*'],
  allowFileAccess: true
}

However it was working correctly on v.2.10.0. And here is a fork of working version that we’re stuck to use in our original app in order to get the right behavior.

To Reproduce: Here is the repo of an example app to reproduce error. You can download and examine the source code that i’m using in the example app

Expected behavior: WebView shouldn’t redirect into Iframe src on Android. The view in the iOS Simulator is expected.

Screenshots/Videos: Screenshots produced at latest version of react-native-webView (5.8.1) Android: (incorrect) iOS: (correct)

Environment:

• OS: macOS Mojave
• OS version: 10.14.4
• react-native version: 0.59.5
• react-native-webview version: > 2.10.0

[github-actions[bot]]

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

[pluspol]

We might have found a fix for this. 😃 It seems that the iOS version contains a check preventing unwanted redirects of the main frame. The Android version doesn’t check this.

The following change to RNCWebViewManager.java adding the main frame check seems to fix the issue:

    @TargetApi(Build.VERSION_CODES.N)
    @Override
    public boolean shouldOverrideUrlLoading(WebView view, WebResourceRequest request) {
      if (!request.isForMainFrame()) {
        return false;
      }

      final String url = request.getUrl().toString();
      return this.shouldOverrideUrlLoading(view, url);
    }